From: Christoph Heiss <c.heiss@proxmox.com>
To: Aaron Lauterer <a.lauterer@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH installer 0/4] assistant: clean up glob patterns & regexes
Date: Mon, 13 May 2024 11:50:36 +0200 [thread overview]
Message-ID: <xdyfg2xqklliasm6s5d2y3m5dwk2sbfiyxka6fxqvm4p35p23c@33g2u46xiprw> (raw)
In-Reply-To: <9adff507-fda2-494d-bf79-307a7c668428@proxmox.com>
On Mon, May 13, 2024 at 11:18:51AM +0200, Aaron Lauterer wrote:
> it seems these patches don't apply anymore. could you please do a rebase on
> current master?
Sure, thanks for the notice!
Seems 1a01a01 ("assistant: keep prepared iso bootable on uefi with flash drives")
"broke" it, due to an import statement change :')
v2: https://lists.proxmox.com/pipermail/pve-devel/2024-May/063833.html
>
> On 2024-05-07 15:21, Christoph Heiss wrote:
> > The proxmox-auto-install-assistant uses
> > - glob patterns for disk matching, which can be pre-compiled for
> > efficiency
> > - regexes for udev property matching, which can be simplified by some
> > simple prefix matching & splitting on =
> >
> > The latter also significantly reduces binary size due to the removing
> > the regex dependency, for details see patch #4.
> >
> > Overall no functional changes in this series.
> >
> > Christoph Heiss (4):
> > tree-wide: run rustfmt, fix clippy warnings
> > assistant: drop unused `log` dependency
> > assistant: pre-compile ignored block device patterns
> > assistant: avoid regex for simple prefix matching
> >
> > proxmox-auto-install-assistant/Cargo.toml | 2 -
> > proxmox-auto-install-assistant/src/main.rs | 75 ++++++++-----------
> > proxmox-auto-installer/tests/parse-answer.rs | 14 ++--
> > .../src/fetch_plugins/partition.rs | 10 +--
> > 4 files changed, 45 insertions(+), 56 deletions(-)
> >
> > --
> > 2.44.0
> >
> >
> >
> > _______________________________________________
> > pve-devel mailing list
> > pve-devel@lists.proxmox.com
> > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> >
> >
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-05-13 9:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 13:21 Christoph Heiss
2024-05-07 13:21 ` [pve-devel] [PATCH installer 1/4] tree-wide: run rustfmt, fix clippy warnings Christoph Heiss
2024-05-07 13:21 ` [pve-devel] [PATCH installer 2/4] assistant: drop unused `log` dependency Christoph Heiss
2024-05-07 13:21 ` [pve-devel] [PATCH installer 3/4] assistant: pre-compile ignored block device patterns Christoph Heiss
2024-05-07 13:21 ` [pve-devel] [PATCH installer 4/4] assistant: avoid regex for simple prefix matching Christoph Heiss
2024-05-13 9:18 ` [pve-devel] [PATCH installer 0/4] assistant: clean up glob patterns & regexes Aaron Lauterer
2024-05-13 9:50 ` Christoph Heiss [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xdyfg2xqklliasm6s5d2y3m5dwk2sbfiyxka6fxqvm4p35p23c@33g2u46xiprw \
--to=c.heiss@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox