From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: "Max R. Carrara" <m.carrara@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: [pve-devel] applied: [PATCH pve-storage v1] fix #6553: lvmthin: implement volume_rollback_is_possible sub
Date: Tue, 22 Jul 2025 14:57:15 +0200 [thread overview]
Message-ID: <weypnpgpjnjleqqd6bwiuul2ofejhl5t625qiuce37y4bdbcwb@7b6qd6dhhuza> (raw)
In-Reply-To: <20250722102610.116215-1-m.carrara@proxmox.com>
applied, thanks
On Tue, Jul 22, 2025 at 12:26:10PM +0200, Max R. Carrara wrote:
> Because LvmThinPlugin.pm uses LVMPlugin.pm as a base, it inherits the
> `volume_rollback_is_possible()` subroutine added in eda88c94. Its
> implementation however causes snapshot rollbacks to fail with
> "can't rollback snapshot for 'raw' volume".
>
> Fix this by implementing `volume_rollback_is_possible()`.
>
> Closes: #6553
> Signed-off-by: Max R. Carrara <m.carrara@proxmox.com>
> ---
> src/PVE/Storage/LvmThinPlugin.pm | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/src/PVE/Storage/LvmThinPlugin.pm b/src/PVE/Storage/LvmThinPlugin.pm
> index 6f8a92e..ccefd0e 100644
> --- a/src/PVE/Storage/LvmThinPlugin.pm
> +++ b/src/PVE/Storage/LvmThinPlugin.pm
> @@ -363,6 +363,12 @@ sub volume_snapshot {
> # disabling autoactivation not needed, as -s defaults to --setautoactivationskip y
> }
>
> +sub volume_rollback_is_possible {
> + my ($class, $scfg, $storeid, $volname, $snap, $blockers) = @_;
> +
> + return 1;
> +}
> +
> sub volume_snapshot_rollback {
> my ($class, $scfg, $storeid, $volname, $snap) = @_;
>
> --
> 2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-07-22 12:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-22 10:26 [pve-devel] " Max R. Carrara
2025-07-22 12:57 ` Wolfgang Bumiller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=weypnpgpjnjleqqd6bwiuul2ofejhl5t625qiuce37y4bdbcwb@7b6qd6dhhuza \
--to=w.bumiller@proxmox.com \
--cc=m.carrara@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox