Re: [PATCH proxmox-ve-rs v7 10/21] frr: add vtysh integration tests for proxmox-frr

[Gabriel Goller <g.goller@proxmox.com>]

On 23.03.2026 14:49, Gabriel Goller wrote:
> Add integration tests that render FrrConfig structs to frr configuration
> text and validate them against a real vtysh (frr) instance. The tests use
> vtysh's dry-run mode, which checks for syntax errors and limited semantic
> errors without requiring the other FRR daemons.
> 
> Tests are split across several files covering common topologies:
>  - BGP/EVPN (leaf/spine iBGP, EVPN-only, IPv6-only, maximal config)
>  - Multi-protocol combinations (BGP + OSPF + IS-IS + OpenFabric)
>  - Route maps, ACLs, prefix lists, protocol route maps
>  - Edge cases (static routes, VRFs with routes, neighbor local-as, etc.)
> 
> Since the tests require a local vtysh installation, the `test-with` crate
> is used to automatically mark them as `ignored` when the vtysh binary is
> not present.
> 
> To allow constructing config structs directly in tests, a few changes
> are made to the serializer types:
>  - Make `IpRoute`, `AddressFamilies`, and `Redistribute` fields public
>  - Expose `create_env()` from `ser/serializer.rs`
>  - Add `IsisRouterName::new` constructor and `From<FrrWord>` impl
>  - Add `PrefixListName::new` constructor
>  - Add `CsnpInterval::new`, `HelloInterval::new`, and
>    `HelloMultiplier::new` constructors in proxmox-sdn-types, each
>    validating the given value against the declared API schema constraints
> 
> Reviewed-by: Hannes Laimer <h.laimer@proxmox.com>
> Tested-by: Stefan Hanreich <s.hanreich@proxmox.com>

Ah, this commit is new and doesn't have a Tested-by and Reviewed-by yet, so
disregard these two lines. Sorry about that!

> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
>  proxmox-frr/Cargo.toml                      |    3 +
>  proxmox-frr/src/ser/bgp.rs                  |    6 +-
>  proxmox-frr/src/ser/isis.rs                 |   16 +-
>  proxmox-frr/src/ser/mod.rs                  |    8 +-
>  proxmox-frr/src/ser/route_map.rs            |    6 +
>  proxmox-frr/src/ser/serializer.rs           |    2 +-
>  proxmox-frr/tests/bgp_evpn.rs               |  844 +++++++++++++
>  proxmox-frr/tests/common/mod.rs             |   69 ++
>  proxmox-frr/tests/fabric_ospf_openfabric.rs |  569 +++++++++
>  proxmox-frr/tests/template_validation.rs    |  676 ++++++++++
>  proxmox-frr/tests/weird_combinations.rs     | 1225 +++++++++++++++++++
>  proxmox-sdn-types/src/openfabric.rs         |   32 +-
>  12 files changed, 3445 insertions(+), 11 deletions(-)
>  create mode 100644 proxmox-frr/tests/bgp_evpn.rs
>  create mode 100644 proxmox-frr/tests/common/mod.rs
>  create mode 100644 proxmox-frr/tests/fabric_ospf_openfabric.rs
>  create mode 100644 proxmox-frr/tests/template_validation.rs
>  create mode 100644 proxmox-frr/tests/weird_combinations.rs
>