From: Gabriel Goller <g.goller@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: applied: [PATCH manager/network/proxmox{-ve-rs,-perl-rs} v8 00/21] Generate frr config using jinja templates and rust types
Date: Tue, 31 Mar 2026 10:29:27 +0200 [thread overview]
Message-ID: <ukct7y45egj2dtzfdvjto7x65nbzsrdqwbm7xbyi2vs464llhi@z6pufzfi2teq> (raw)
In-Reply-To: <177471674432.3099145.14191595895230112822.b4-ty@proxmox.com>
On 28.03.2026 17:55, Thomas Lamprecht wrote:
> On Fri, 27 Mar 2026 16:01:03 +0100, Gabriel Goller wrote:
> > Previously we generated the frr config using one big perl hash, where every
> > controller-plugin and zone-plugin would push their stuff. This is not pretty
> > and also tricky to unite with our new rust-based fabrics. Furthermore the only
> > way to edit or override the frr config is currently the frr.conf.local file,
> > which is merged with the perl-hash in a very janky manner, which has sprouted
> > numerous forum threads. The main problem with the frr.conf.local is the limited
> > control which the user has as to where the override or additional config gets
> > placed. There are also a few config overrides or additions to frr.conf.local
> > that are currently impossible or generate invalid frr config.
> >
> > [...]
>
> Applied the following parts, thanks!
>
> proxmox-ve-rs:
> [1/9] ve-config: firewall: cargo fmt
> commit: 5901f899a77eb853e02dfef33eac1b07f826e7b6
> [2/9] frr: add proxmox-frr-templates package that contains templates
> commit: 7d912a192d070d7e68b1e6c00b70a9cad1256ad0
> [3/9] ve-config: remove FrrConfigBuilder struct
> commit: 4712a934875e117144975b11d2b24f7185990adc
> [4/9] sdn-types: support variable-length NET identifier
> commit: c6c1be318e1f8941e31abf5580f25b519ee2dd12
> [5/9] frr: add template serializer and serialize fabrics using templates
> commit: 1ca7bb01f6bd175c4b4496b7146bd13bc113a25d
> [6/9] frr: add isis configuration and templates
> commit: 4198f041b5f7c70a66f2c60885d3d3858946186b
> [7/9] frr: support custom frr configuration lines
> commit: 9cdffc5eab293455c075c17c3d21b28200a5d048
> [8/9] frr: add bgp support with templates and serialization
> commit: 900291179b1c0ee12d67d8fbef429bbd7b97958b
> [9/9] frr: enable minijinja strict undefined behavior mode
> commit: e97efc0574479b9e7ca0a75147f65627dd34caf5
Note that patch 10 is still in the approval queue!
next prev parent reply other threads:[~2026-03-31 8:29 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 15:01 Gabriel Goller
2026-03-27 15:01 ` [PATCH proxmox-ve-rs v8 01/21] ve-config: firewall: cargo fmt Gabriel Goller
2026-03-27 15:01 ` [PATCH proxmox-ve-rs v8 02/21] frr: add proxmox-frr-templates package that contains templates Gabriel Goller
2026-03-27 15:01 ` [PATCH proxmox-ve-rs v8 03/21] ve-config: remove FrrConfigBuilder struct Gabriel Goller
2026-03-27 15:01 ` [PATCH proxmox-ve-rs v8 04/21] sdn-types: support variable-length NET identifier Gabriel Goller
2026-03-27 15:01 ` [PATCH proxmox-ve-rs v8 05/21] frr: add template serializer and serialize fabrics using templates Gabriel Goller
2026-03-27 15:01 ` [PATCH proxmox-ve-rs v8 06/21] frr: add isis configuration and templates Gabriel Goller
2026-03-27 15:01 ` [PATCH proxmox-ve-rs v8 07/21] frr: support custom frr configuration lines Gabriel Goller
2026-03-27 15:01 ` [PATCH proxmox-ve-rs v8 08/21] frr: add bgp support with templates and serialization Gabriel Goller
2026-03-27 15:01 ` [PATCH proxmox-ve-rs v8 09/21] frr: enable minijinja strict undefined behavior mode Gabriel Goller
2026-03-27 15:01 ` [PATCH proxmox-ve-rs v8 10/21] frr: add vtysh integration tests for proxmox-frr Gabriel Goller
2026-03-27 15:01 ` [PATCH proxmox-perl-rs v8 11/21] sdn: add function to generate the frr config for all daemons Gabriel Goller
2026-03-27 15:01 ` [PATCH pve-network v8 12/21] tests: use Test::Differences to make test assertions Gabriel Goller
2026-03-27 15:01 ` [PATCH pve-network v8 13/21] test: add tests for frr.conf.local merging Gabriel Goller
2026-03-27 15:01 ` [PATCH pve-network v8 14/21] test: bgp: add some various integration tests Gabriel Goller
2026-03-27 15:01 ` [PATCH pve-network v8 15/21] sdn: write structured frr config that can be rendered using templates Gabriel Goller
2026-03-27 15:01 ` [PATCH pve-network v8 16/21] sdn: remove duplicate comment line '!' in frr config Gabriel Goller
2026-03-27 15:01 ` [PATCH pve-network v8 17/21] tests: rearrange some statements in the " Gabriel Goller
2026-03-27 15:01 ` [PATCH pve-network v8 18/21] sdn: adjust frr.conf.local merging to rust template types Gabriel Goller
2026-03-27 15:01 ` [PATCH pve-network v8 19/21] test: adjust frr_local_merge test for new template generation Gabriel Goller
2026-03-27 15:01 ` [PATCH pve-network v8 20/21] api: add dry-run endpoint for sdn apply to preview changes Gabriel Goller
2026-03-27 15:01 ` [PATCH pve-manager v8 21/21] sdn: add dry-run diff view for sdn apply Gabriel Goller
2026-03-28 20:19 ` Thomas Lamprecht
2026-03-30 12:04 ` Gabriel Goller
2026-03-28 16:55 ` applied: [PATCH manager/network/proxmox{-ve-rs,-perl-rs} v8 00/21] Generate frr config using jinja templates and rust types Thomas Lamprecht
2026-03-31 8:29 ` Gabriel Goller [this message]
2026-03-31 8:35 ` Thomas Lamprecht
2026-03-31 8:44 ` Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ukct7y45egj2dtzfdvjto7x65nbzsrdqwbm7xbyi2vs464llhi@z6pufzfi2teq \
--to=g.goller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox