From: Christoph Heiss <c.heiss@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH installer v2 0/3] expose zfs arc size setting for all products
Date: Mon, 15 Apr 2024 15:21:53 +0200 [thread overview]
Message-ID: <ug72gmpwbhpc7pgc3qezt3lvonl2mfwkwf4sxil75xqqln4olv@qqgjvb67l5z2> (raw)
In-Reply-To: <20240207142824.2613933-1-c.heiss@proxmox.com>
v3: https://lists.proxmox.com/pipermail/pve-devel/2024-April/062976.html
On Wed, Feb 07, 2024 at 03:28:11PM +0100, Christoph Heiss wrote:
> As suggested by Thomas, leaves the ZFS default if the user never touches
> the setting in the installer (i.e. not writing a modprobe file).
> See also the discussion in v1 [0].
>
> [0] https://lists.proxmox.com/pipermail/pve-devel/2024-February/061659.html
>
> Testing
> -------
> Tested the installation of PVE and PBS, with each once letting the arc
> size setting untouched and once setting it to some specific value.
> Afterwards, checked that for PVE the module parameter was always written
> to /etc/modprobe.d/, for PBS that it was only written in case it was
> set.
>
> Previous revisions
> ------------------
> v1: https://lists.proxmox.com/pipermail/pve-devel/2023-November/060898.html
>
> Changes v1 -> v2:
> * rebased on latest master
> * add placeholder functionality for arc max size in TUI
> * "emulate" placeholder functionality in GTK on best-effort basis
>
> Christoph Heiss (3):
> tui: NumericEditView: add optional placeholder value
> tui: expose arc size setting for zfs bootdisks for all products
> proxinstall: expose arc size setting for zfs bootdisks for all
> products
>
> Proxmox/Install/RunEnv.pm | 3 +-
> proxinstall | 37 +++++++----
> proxmox-installer-common/src/options.rs | 3 +-
> proxmox-tui-installer/src/views/bootdisk.rs | 48 ++++++++------
> proxmox-tui-installer/src/views/mod.rs | 69 +++++++++++++++++++--
> 5 files changed, 124 insertions(+), 36 deletions(-)
>
> --
> 2.42.0
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
prev parent reply other threads:[~2024-04-15 13:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 14:28 Christoph Heiss
2024-02-07 14:28 ` [pve-devel] [PATCH installer v2 1/3] tui: NumericEditView: add optional placeholder value Christoph Heiss
2024-02-07 14:28 ` [pve-devel] [PATCH installer v2 2/3] tui: expose arc size setting for zfs bootdisks for all products Christoph Heiss
2024-02-07 14:28 ` [pve-devel] [PATCH installer v2 3/3] proxinstall: " Christoph Heiss
2024-02-23 15:37 ` Maximiliano Sandoval
2024-04-12 10:26 ` Christoph Heiss
2024-04-15 13:21 ` Christoph Heiss [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ug72gmpwbhpc7pgc3qezt3lvonl2mfwkwf4sxil75xqqln4olv@qqgjvb67l5z2 \
--to=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox