public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: Maximiliano Sandoval <m.sandoval@proxmox.com>
Cc: pve-devel@lists.proxmox.com, Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: Re: [pve-devel] [PATCH installer 3/3] fix #2502: proxinstall: set cidr text manually
Date: Tue, 17 Dec 2024 16:26:27 +0100	[thread overview]
Message-ID: <s8oseqme3ec.fsf@proxmox.com> (raw)
In-Reply-To: <20241217152316.381557-3-m.sandoval@proxmox.com>


> Instead of relying on the device_change_handler callback (which saves
> the config) we manually set the text to the right value.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---

I am not completely sure if this patch series preserves the intentional
UI flow. Some testing would be welcome.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      reply	other threads:[~2024-12-17 15:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-17 15:23 [pve-devel] [PATCH installer 1/3] proxinstall: move device changed callback after loop Maximiliano Sandoval
2024-12-17 15:23 ` [pve-devel] [PATCH installer 2/3] proxinstall: set active element in combo box once Maximiliano Sandoval
2024-12-17 15:23 ` [pve-devel] [PATCH installer 3/3] fix #2502: proxinstall: set cidr text manually Maximiliano Sandoval
2024-12-17 15:26   ` Maximiliano Sandoval [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s8oseqme3ec.fsf@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal