[pve-devel] [PATCH installer] gui: fall back to first found NIC if no default could be determined

[pve-devel] [PATCH installer] gui: fall back to first found NIC if no default could be determined

[Christoph Heiss]

If no DHCP server is configured on the network and/or no DHCP lease and
thus network configuration is retrieved, the installer will also be
unable to determine the default interface, aka. the one with the default
gateway set.

Fix it by pre-selecting the first found interface. If we *do* have a
default interface, the index will be later overwritten, but ensures that
always *some* interface is pre-selected in the dropdown.

As it is already checked that the machine has any network interfaces
before starting the installation wizard, it is safe to rely on the fact
that at least one NIC must be present.

For completeness, all the other network inputs already have (hardcoded)
fallbacks, namely 192.168.100.2/24 as address/netmask, 192.168.100.1 as
gateway and the gateway address as DNS server address.

Reported-by: Christian Ebner <c.ebner@proxmox.com>
Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
 proxinstall | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/proxinstall b/proxinstall
index d396375..bc9ade6 100755
--- a/proxinstall
+++ b/proxinstall
@@ -389,7 +389,7 @@ sub create_ipconf_view {
 	    if $iface->{inet}->{prefix} || $iface->{inet6}->{prefix};
     };
 
-    my ($initial_active_device_pos, $initial_addr, $initial_mask) = (-1, undef, undef);
+    my ($initial_active_device_pos, $initial_addr, $initial_mask) = (0, undef, undef);
 
     my $i = 0;
     for my $index (sort keys $ipconf->{ifaces}->%*) {
@@ -402,7 +402,8 @@ sub create_ipconf_view {
 	);
 	$device_active_map->{$i} = $index;
 	$device_active_reverse_map->{$iface->{name}} = $i;
-	if ($index == $ipconf->{default}) {
+
+	if (defined($ipconf->{default}) && $index == $ipconf->{default}) {
 	    $initial_active_device_pos = $i;
 	    $initial_addr = $iface->{inet}->{addr} || $iface->{inet6}->{addr};
 	    $initial_mask = $iface->{inet}->{prefix} || $iface->{inet6}->{prefix};
@@ -412,7 +413,7 @@ sub create_ipconf_view {
 
     if (my $nic = Proxmox::Install::Config::get_mngmt_nic()) {
 	$initial_active_device_pos = $device_active_reverse_map->{$nic};
-    } elsif ($initial_active_device_pos >= 0) {
+    } else {
 	my $iface_id = $device_active_map->{$initial_active_device_pos};
 	my $iface = $ipconf->{ifaces}->{$iface_id};
 	Proxmox::Install::Config::set_mngmt_nic($iface->{name});
-- 
2.48.1



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH installer] gui: fall back to first found NIC if no default could be determined

[Thomas Lamprecht]

On Mon, 07 Apr 2025 15:55:07 +0200, Christoph Heiss wrote:
> If no DHCP server is configured on the network and/or no DHCP lease and
> thus network configuration is retrieved, the installer will also be
> unable to determine the default interface, aka. the one with the default
> gateway set.
> 
> Fix it by pre-selecting the first found interface. If we *do* have a
> default interface, the index will be later overwritten, but ensures that
> always *some* interface is pre-selected in the dropdown.
> 
> [...]

Applied, thanks!

[1/1] gui: fall back to first found NIC if no default could be determined
      commit: c53166998d0e312f5ecf95b305ffd9993e03c98a


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH installer] gui: fall back to first found NIC if no default could be determined

[Maximiliano Sandoval]

Christoph Heiss <c.heiss@proxmox.com> writes:

> If no DHCP server is configured on the network and/or no DHCP lease and
> thus network configuration is retrieved, the installer will also be
> unable to determine the default interface, aka. the one with the default
> gateway set.
>
> Fix it by pre-selecting the first found interface. If we *do* have a
> default interface, the index will be later overwritten, but ensures that
> always *some* interface is pre-selected in the dropdown.
>
> As it is already checked that the machine has any network interfaces
> before starting the installation wizard, it is safe to rely on the fact
> that at least one NIC must be present.
>
> For completeness, all the other network inputs already have (hardcoded)
> fallbacks, namely 192.168.100.2/24 as address/netmask, 192.168.100.1 as
> gateway and the gateway address as DNS server address.
>
> Reported-by: Christian Ebner <c.ebner@proxmox.com>
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>


I am a bit late here, I tested this patch with either one or three NICs
and with and without a working DHCP server. I did not notice any
regression.

Tested-by: Maximiliano Sandoval <m.sandoval@proxmox.com>


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel