Re: [RFC cluster 1/2] datacenter config: add dynamic load scheduler option

[Maximiliano Sandoval <m.sandoval@proxmox.com>]

Daniel Kral <d.kral@proxmox.com> writes:

> Signed-off-by: Daniel Kral <d.kral@proxmox.com>
> ---
>  src/PVE/DataCenterConfig.pm | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfig.pm
> index 514c867..5c91f80 100644
> --- a/src/PVE/DataCenterConfig.pm
> +++ b/src/PVE/DataCenterConfig.pm
> @@ -13,13 +13,14 @@ my $PROXMOX_OUI = 'BC:24:11';
>  my $crs_format = {
>      ha => {
>          type => 'string',
> -        enum => ['basic', 'static'],
> +        enum => ['basic', 'static', 'dynamic'],
>          optional => 1,
>          default => 'basic',
>          description => "Use this resource scheduler mode for HA.",
>          verbose_description => "Configures how the HA manager should select nodes to start or "
>              . "recover services. With 'basic', only the number of services is used, with 'static', "
> -            . "static CPU and memory configuration of services is considered.",
> +            . "static CPU and memory configuration of services is considered, and with 'dynamic', "
> +            . "static and dynamic CPU and memory usage of services is considered.",

I would personally add a full stop and rephrase a bit e.g.:

...static CPU and memory configuration of services is considered. When
set to 'dynamic' static CPU usage, dynamic CPU usage, and memory usage
of services is considered.

-- 
Maximiliano