Re: [pve-devel] [PATCH installer] gui: always set visible-child-name on disk dialog

[Maximiliano Sandoval <m.sandoval@proxmox.com>]

"Christoph Heiss" <c.heiss@proxmox.com> writes:

> On Tue Mar 4, 2025 at 11:49 AM CET, Maximiliano Sandoval wrote:
>> Whenever a filesystem is selected we show the size selection stack page.
>>
>> At the moment entering any raid setup, then entering the Advanced
>> Options page and then selecting any non-raid setup will show the
>> raiddisk page since it is still the visible child.
>
> While testing this, I cannot seem to reproduce the original problem on
> the latest PVE 8.3-1 ISO.
> In the GUI, clicking on "Options" besides the target harddisk, then in
> the dialog selecting e.g. "zfs (RAID1)", going to the "Advanced Options"
> tab and then selecting e.g. "ext4" above, yields the normal disk sizing
> options tab as expected.


You are right, I just noticed that not all raid setups reproduce this
issue. Selecting the advanced options in "btrfs (RAID10)" and going back
to ext4, for example, reproduces the issue.

> On the main disk selection page, the dropdown is also updated
> accordingly.
>
> Or is some other combination of inputs required to trigger this bug?
> This is just based upon the patch description.

The commit message should be updated, I will do that if there is a need
for v2.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel