From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: superseded: [PATCH ha-manager v2] resources: Expand max_restart option
Date: Wed, 04 Mar 2026 09:36:44 +0100 [thread overview]
Message-ID: <s8oldg8j8ir.fsf@toolbox> (raw)
In-Reply-To: <20260303132206.222398-1-m.sandoval@proxmox.com> (Maximiliano Sandoval's message of "Tue, 3 Mar 2026 14:22:05 +0100")
Maximiliano Sandoval <m.sandoval@proxmox.com> writes:
> When read next to `max_relocate` it is not clear which happens first
> after a service fails to start.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
>
> ---
>
> Differences from v1:
> - Incorporate feedback. Namely, "the service will be attempted to be relocated"
> was a bit too convoluted.
>
> src/PVE/HA/Resources.pm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/PVE/HA/Resources.pm b/src/PVE/HA/Resources.pm
> index 68d9d16..404f6dc 100644
> --- a/src/PVE/HA/Resources.pm
> +++ b/src/PVE/HA/Resources.pm
> @@ -73,7 +73,8 @@ EODESC
> },
> max_restart => {
> description => "Maximal number of tries to restart the service on"
> - . " a node after its start failed.",
> + . " a node after its start failed. When reached, the HA manager will try to"
> + . " relocate the service to an eligible node.",
> type => 'integer',
> optional => 1,
> default => 1,
Superseded-by: https://lore.proxmox.com/all/20260304083559.75293-1-m.sandoval@proxmox.com/
--
Maximiliano
prev parent reply other threads:[~2026-03-04 8:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 13:22 Maximiliano Sandoval
2026-03-03 16:46 ` Michael Köppl
2026-03-03 20:09 ` Thomas Lamprecht
2026-03-04 7:58 ` Daniel Kral
2026-03-04 8:36 ` Maximiliano Sandoval [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s8oldg8j8ir.fsf@toolbox \
--to=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox