Re: [pve-devel] [PATCH qemu-server v5 8/9] deprecate freeze-fs-on-backup qga setting

[Maximiliano Sandoval <m.sandoval@proxmox.com>]

Thomas Lamprecht <t.lamprecht@proxmox.com> writes:

> Am 05.01.26 um 13:17 schrieb Maximiliano Sandoval:
>> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
>> ---
>>  src/PVE/QemuServer/Agent.pm | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>> 
>> diff --git a/src/PVE/QemuServer/Agent.pm b/src/PVE/QemuServer/Agent.pm
>> index 7193d015..05ff4cae 100644
>> --- a/src/PVE/QemuServer/Agent.pm
>> +++ b/src/PVE/QemuServer/Agent.pm
>> @@ -35,8 +35,10 @@ our $agent_fmt = {
>>          optional => 1,
>>          default => 0,
>>      },
>> +    # TODO Remove for Proxmox VE 10
>>      'freeze-fs-on-backup' => {
>> -        description => "Freeze/thaw guest filesystems on backup for consistency.",
>> +        description => "Deprecated: Use 'guest-fsfreeze' instead.\n\n"
>> +            . " Freeze/thaw guest filesystems on backup for consistency.",
>>          type => 'boolean',
>>          optional => 1,
>>          default => 1,
>
> why not just make this an alias for the new (superset) property?

I was not aware of aliases for props, where can I see an example?

> And you certainly *cannot* remove this in PVE 10, doing so will break
> restoring previous backups!

Just to be clear, one should just remove the TODO comment?

> This needs some fixing up please.

-- 
Maximiliano