Re: [PATCH pve-manager 1/4] ui: iso selector: add option to warn about virtio versions with issues

[Maximiliano Sandoval <m.sandoval@proxmox.com>]

Nicolas Frey <n.frey@proxmox.com> writes:

> based on the known issues as seen on the wiki. If warnVirtio is true,
> the filename is matched against "virtio-win-x.x.x.iso" and checks
> whether the version number in the filename is in any "from - to" version
> range in `virtioIssues`.
>
> Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
> ---
>  www/manager6/form/IsoSelector.js | 68 +++++++++++++++++++++++++++++++-
>  1 file changed, 66 insertions(+), 2 deletions(-)
>
> diff --git a/www/manager6/form/IsoSelector.js b/www/manager6/form/IsoSelector.js
> index b2d94ed3..ae6b8d65 100644
> --- a/www/manager6/form/IsoSelector.js
> +++ b/www/manager6/form/IsoSelector.js
> @@ -10,6 +10,7 @@ Ext.define('PVE.form.IsoSelector', {
>  
>      nodename: undefined,
>      insideWizard: false,
> +    warnVirtio: false,
>      labelWidth: undefined,
>      labelAlign: 'right',
>  
> @@ -63,6 +64,61 @@ Ext.define('PVE.form.IsoSelector', {
>          return me.callParent([disabled]);
>      },
>  
> +    virtioIssues: [
> +        {
> +            from: '0.1.215',
> +            to: '0.1.262',
> +            message: gettext('Upgrading to version 0.1.266 or newer is recommended.'),
> +        },
> +        {
> +            from: '0.1.285',
> +            to: '0.1.285',
> +            message: gettext('Downgrading to version 0.1.271 is recommended.'),
> +        },
> +    ],
> +
> +    checkVirtioVersion: function (filename) {
> +        let me = this;
> +        let warningBox = me.lookup('virtioWarning');
> +
> +        const compareVersions = (a, b) => {
> +            let pa = a.split('.').map(Number);
> +            let pb = b.split('.').map(Number);
> +            let max = Math.max(pa.length, pb.length);
> +            for (let i = 0; i < max; i++) {
> +                let cmp = (pa[i] || 0) - (pb[i] || 0);
> +                if (cmp !== 0) {
> +                    return cmp;
> +                }
> +            }
> +            return 0;
> +        };
> +
> +        let match = (filename || '').match(/virtio-win[_-](\d+\.\d+\.\d+)/i);
> +        let version = match && match[1];
> +        let issue =
> +            version &&
> +            me.virtioIssues.find(
> +                (i) => compareVersions(version, i.from) >= 0 && compareVersions(version, i.to) <= 0,
> +            );
> +
> +        if (!issue) {
> +            warningBox.setHtml('');
> +            return;
> +        }
> +
> +        warningBox.setHtml(
> +            '<i class="fa fa-exclamation-triangle warning"></i> ' +
> +                gettext('This VirtIO driver version is known to') +
> +                ' ' +
> +                `<a href="https://pve.proxmox.com/wiki/Windows_VirtIO_Drivers#Known_issues" target="_blank">${gettext(
> +                    'cause issues',
> +                )}</a>` +
> +                '. ' +

Please use a single gettext call in conjunction with format, e.g.
something like

    Ext.String.format(gettext('Version {0} of the VirtIO drivers is
    known to causes issues. See {1} for more details), version, uri_with_html_blocks)

> +                issue.message,
> +        );
> +    },
> +
>      referenceHolder: true,
>  
>      items: [
> @@ -105,10 +161,18 @@ Ext.define('PVE.form.IsoSelector', {
>              },
>              allowBlank: false,
>              listeners: {
> -                change: function () {
> -                    this.up('pveIsoSelector').checkChange();
> +                change: function (_field, value) {
> +                    let selector = this.up('pveIsoSelector');
> +                    if (selector.warnVirtio) {
> +                        selector.checkVirtioVersion(value);
> +                    }
> +                    selector.checkChange();
>                  },
>              },
>          },
> +        {
> +            xtype: 'displayfield',
> +            reference: 'virtioWarning',
> +        },
>      ],
>  });

-- 
Maximiliano