public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 1/2] ceph: remove global pg bits setting
Date: Wed, 20 Sep 2023 15:42:03 +0200	[thread overview]
Message-ID: <s8ojzslx75d.fsf@proxmox.com> (raw)
In-Reply-To: <ee5e4e70-e381-4f29-bbd0-1021f5f97f34@proxmox.com>


Thomas Lamprecht <t.lamprecht@proxmox.com> writes:

> @maximiliano: how does ceph react if one sets this currently?
> I.e., does it silently accepts unknown config keys, or does it break
> something?

Running

    ceph config set global osd_pg_bits 42

results in

    Error EINVAL: unrecognized config option 'osd_pg_bits'

Having them set on /etc/pve/ceph.conf on the other hand does not throw
any kind of warning as far as I can tell, but I suspect it does not do
anything either.

Please tell if I am missing something or if I should do a new version of
the patch.

--
Maximiliano




  reply	other threads:[~2023-09-20 14:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-07  9:49 Maximiliano Sandoval
2023-09-07  9:49 ` [pve-devel] [PATCH manager 2/2] ceph: api: use snake_case when setting options Maximiliano Sandoval
2023-09-20 12:10 ` [pve-devel] [PATCH manager 1/2] ceph: remove global pg bits setting Dominik Csapak
2023-09-20 13:21   ` Thomas Lamprecht
2023-09-20 13:42     ` Maximiliano Sandoval [this message]
2023-09-20 14:27       ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s8ojzslx75d.fsf@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal