public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: superseded: [PATCH qemu-server v2] api: qmclone: print a message with new VMID
Date: Mon, 16 Mar 2026 12:39:47 +0000	[thread overview]
Message-ID: <s8ojyvcq770.fsf@toolbox> (raw)
In-Reply-To: <2ff216bd-1823-472b-b45c-49beefa65d5f@proxmox.com> (Fiona Ebner's message of "Mon, 16 Mar 2026 12:02:56 +0100")

Fiona Ebner <f.ebner@proxmox.com> writes:

> Am 16.03.26 um 11:13 AM schrieb Maximiliano Sandoval:
>> When doing a linked clone of a template, the task log, journal, nor the
>> UPID of the task will log the VMID of the newly created VM.
>> 
>> We add a log message at the start of the clone. This affects both full
>> and linked clones.
>
> Could you send a patch for containers too to keep it consistent?
>
>> diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm
>> index 1e226f6f..0587ff97 100644
>> --- a/src/PVE/API2/Qemu.pm
>> +++ b/src/PVE/API2/Qemu.pm
>> @@ -4487,6 +4487,9 @@ __PACKAGE__->register_method({
>>          my $clonefn = sub {
>>              my ($conffile, $newconf, $oldconf, $vollist, $drives, $fullclone) =
>>                  $load_and_check->();
>> +
>> +            print("creating a clone of $vmid with ID $newid\n");
>
> I think we should put "of VM $vmid" rather than just the ID like we do
> in other messages.
>
>> +
>>              my $storecfg = PVE::Storage::config();
>>  
>>              # auto generate a new uuid

Superseded-by: https://lore.proxmox.com/all/20260316123820.333308-1-m.sandoval@proxmox.com/T/#u

-- 
Maximiliano




      reply	other threads:[~2026-03-16 12:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-16 10:14 Maximiliano Sandoval
2026-03-16 11:02 ` Fiona Ebner
2026-03-16 12:39   ` Maximiliano Sandoval [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s8ojyvcq770.fsf@toolbox \
    --to=m.sandoval@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal