From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH widget-toolkit] i18n: mark strings as translatable
Date: Wed, 06 Dec 2023 15:04:42 +0100 [thread overview]
Message-ID: <s8oh6kvmn7g.fsf@proxmox.com> (raw)
In-Reply-To: <97caa32b-eb4d-434e-965c-b65d51761a41@proxmox.com>
Dominik Csapak <d.csapak@proxmox.com> writes:
> it's more like DHCP, SLAAC or IPv4. those are names of protocols (like ACME)
> that shouldn't change across translations
>
> and we removed those gettexts (mostly) a while ago
> e.g. see lxc/Network.js in pve-manager:
>
> ---8<---
> boxLabel: 'DHCP', // do not localize
> --->8---
Do note the following examples:
#: pve-manager/www/manager6/qemu/IPConfigEdit.js:97
#: pve-manager/www/manager6/qemu/IPConfigEdit.js:155
msgid "DHCP"
msgstr "بروتوكول التهيئة الآلية للمضيفين (DHCP)"
#: pve-manager/www/manager6/qemu/IPConfigEdit.js:163
msgid "SLAAC"
msgstr "Autoconfiguration SLAAC"
#: pve-manager/www/manager6/ceph/CephInstallWizard.js:476
msgid "First Ceph monitor"
msgstr "أول جهاز مراقبة"
What would be the purpose of removing the translation of the words
themselves if they are already being translated elsewhere.
--
Maximiliano
next prev parent reply other threads:[~2023-12-06 14:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 13:21 Maximiliano Sandoval
2023-12-06 9:46 ` Dominik Csapak
2023-12-06 10:21 ` Maximiliano Sandoval
2023-12-06 11:00 ` Dominik Csapak
2023-12-06 11:13 ` Maximiliano Sandoval
2023-12-06 11:19 ` Dominik Csapak
2023-12-06 11:20 ` Fiona Ebner
2023-12-06 11:22 ` Dominik Csapak
2023-12-06 14:04 ` Maximiliano Sandoval [this message]
2023-12-06 14:26 ` Dominik Csapak
2023-12-06 15:54 ` Thomas Lamprecht
2023-12-06 15:16 ` Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s8oh6kvmn7g.fsf@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox