From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: Aaron Lauterer <a.lauterer@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH storage v3] fix #4272: btrfs: add rename feature
Date: Fri, 05 Jul 2024 14:41:07 +0200 [thread overview]
Message-ID: <s8oh6d4ko4c.fsf@proxmox.com> (raw)
In-Reply-To: <16f29fdd-8a9c-4c7f-8fdd-8664d0a2c041@proxmox.com> (Aaron Lauterer's message of "Thu, 4 Jul 2024 16:47:30 +0200")
Aaron Lauterer <a.lauterer@proxmox.com> writes:
> gave it a try and it does what it should.
> by enabling the rename feature only for `raw` we avoid potential pitfalls if we
> encounter a non regular situation on BTRFS. For example, an
> images/{vmid}/vm-{vmid}-disk-X.qcow2 file directly instead of the
> images/{vmid}/vm-{vmid}-disk-X/disk.raw as is the way the BTRFS plugin handles
> it in subvolumes.
>
> But if we add the following diff, it seems to handle the case of a qcow2 file in
> the same directory structure just fine:
Did you try it without your patch? I tested it here and it seemed to
work from my limited testing.
--
Maximiliano
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-07-05 12:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-04 12:02 Maximiliano Sandoval
2024-07-04 14:47 ` Aaron Lauterer
2024-07-05 12:41 ` Maximiliano Sandoval [this message]
2024-07-05 12:57 ` Aaron Lauterer
2024-07-05 13:14 ` Maximiliano Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s8oh6d4ko4c.fsf@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox