Re: [pve-devel] [PATCH cluster 1/5] pmxcfs: status: add one more missing g_free

[Maximiliano Sandoval <m.sandoval@proxmox.com>]

Lukas Wagner <l.wagner@proxmox.com> writes:

> Otherwise we leak the memory that was already allocated for `filename`.
>
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
>  src/pmxcfs/status.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/pmxcfs/status.c b/src/pmxcfs/status.c
> index a00e793..886d0bd 100644
> --- a/src/pmxcfs/status.c
> +++ b/src/pmxcfs/status.c
> @@ -1369,6 +1369,8 @@ static void update_rrd_data(const char *key, gconstpointer data, size_t len) {
>          } else if (g_file_test(filename_pve2, G_FILE_TEST_EXISTS)) {
>              // old file exists, use it
>              use_pve2_file = 1;
> +
> +            g_free(filename);
>              filename = g_strdup_printf("%s", filename_pve2);
>          } else {
>              // neither file exists, check for directories to decide and create file

I tested this series against a 9.0 (beta) cluster and I didn't see
anything off while writing data to the pmxcfs.

I also did a light review of the code and it looks good.

Tested-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
Reviewed-by: Maximiliano Sandoval <m.sandoval@proxmox.com>

-- 
Maximiliano


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel