Re: [pve-devel] [PATCH docs 2/2] firmware-updates: add group header to fwupd.conf

[Maximiliano Sandoval <m.sandoval@proxmox.com>]

Fabian Grünbichler <f.gruenbichler@proxmox.com> writes:

> On December 29, 2025 2:39 pm, Maximiliano Sandoval wrote:
>> After creating a new config file, either as daemon.conf or fwupd.conf
>> with the same contents as the example prior to this commit, the
>> following error will be seen when starting fwupd.service:
>> 
>> Failed to load daemon: failed to load engine: Failed to load config: failed to load /etc/fwupd/fwupd.conf: Key file does not start with a group
>> 
>> Since there are potentially multiple groups, adding this at the end of
>> the file might result in the key added to the wrong group. The file is
>> also not present by default, so creating it without the header will also
>> lead to issues. On the other hand, adding the group multiple times is
>> not an issue.
>> 
>> Please see `man 5 fwupd.conf` for more details.
>> 
>> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
>> ---
>>  firmware-updates.adoc | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/firmware-updates.adoc b/firmware-updates.adoc
>> index 9ca4b6e..b9ca47e 100644
>> --- a/firmware-updates.adoc
>> +++ b/firmware-updates.adoc
>> @@ -57,6 +57,7 @@ mount point of the EFI partition in `/etc/fwupd/fwupd.conf`, for example:
>>  
>>  .File `/etc/fwupd/fwupd.conf`
>>  ----
>> +[fwupd]
>>  # Override the location used for the EFI system partition (ESP) path.
>>  EspLocation=/boot/efi
>
> does this still work/did you actually test this change?
>
> AFAIK, fwupd now requires udisk to lookup the ESP, it is no longer
> possible to override this:
>
> https://bugzilla.proxmox.com/show_bug.cgi?id=6654

You are right, it does not work. Would it be OK to remove the following
from the documentation

```
That means you must explicitly configure the correct
mount point of the EFI partition in `/etc/fwupd/daemon.conf`, for example:

.File `/etc/fwupd/daemon.conf`
```

for now?

-- 
Maximiliano