Re: [PATCH pve-manager v2 2/2] fix #8031: write APT proxy config on http_proxy change

[Maximiliano Sandoval <m.sandoval@proxmox.com>]

Jonas Theisen <j.theisen@proxmox.com> writes:

> Writes the necessary file for APT if the http_proxy variable
> on the datacenter level is changed.
>
> This reuses the same function from the APT API for a regular
> database update.
>
> Signed-off-by: Jonas Theisen <j.theisen@proxmox.com>
> ---
>  PVE/API2/Cluster.pm | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/PVE/API2/Cluster.pm b/PVE/API2/Cluster.pm
> index 4e5efbfd..8529c026 100644
> --- a/PVE/API2/Cluster.pm
> +++ b/PVE/API2/Cluster.pm
> @@ -36,6 +36,7 @@ use PVE::API2::ClusterConfig;
>  use PVE::API2::Firewall::Cluster;
>  use PVE::API2::HAConfig;
>  use PVE::API2::ReplicationConfig;
> +use PVE::API2::APT;
>  
>  my $have_sdn;
>  eval {
> @@ -842,7 +843,11 @@ __PACKAGE__->register_method({
>      code => sub {
>          my ($param) = @_;
>  
> +        my $http_proxy_change = 0;
> +
>          my $delete = extract_param($param, 'delete');
> +        $http_proxy_change = 1
> +            if ((defined($param->{http_proxy})) || (defined($delete) && $delete =~ m/\bhttp_proxy\b/ ));

Cosmetic stuff: Please run a 'make tidy' to format this file. the
whitespace before the '))' at the end will probably trigger the
formatter. I don't think you need to use two levels of parenthesis
either on the defined($param->{http_proxy} part, but the formatter won't
fix that automatically.

Regarding the '\b', they look correct to me but I am not sure if this is
necessary. This is not a blocked in any case.

>  
>          cfs_lock_file(
>              'datacenter.cfg',
> @@ -859,6 +864,10 @@ __PACKAGE__->register_method({
>          );
>          die $@ if $@;
>  
> +        if ($http_proxy_change) {
> +            PVE::API2::APT::update_apt_proxy_config();
> +        }
> +
>          return undef;
>      },
>  });

Other than that, the patch looks good to me.

Reviewed-by: Maximiliano Sandoval <m.sandoval@proxmox.com>

-- 
Maximiliano