From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH proxmox-widget-toolkit 3/3] notification: smtp: don't split translatable string
Date: Fri, 27 Jun 2025 14:22:17 +0200 [thread overview]
Message-ID: <s8objq9tlui.fsf@proxmox.com> (raw)
In-Reply-To: <20250627121339.182283-3-l.wagner@proxmox.com>
Lukas Wagner <l.wagner@proxmox.com> writes:
> Splitting a string can make it harder or even impossible to provide an
> accurate translation.
>
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> src/panel/SmtpEditPanel.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/panel/SmtpEditPanel.js b/src/panel/SmtpEditPanel.js
> index a7cfaff..37e4d51 100644
> --- a/src/panel/SmtpEditPanel.js
> +++ b/src/panel/SmtpEditPanel.js
> @@ -76,7 +76,7 @@ Ext.define('Proxmox.panel.SmtpEditPanel', {
> fieldLabel: gettext('Encryption'),
> editable: false,
> comboItems: [
> - ['insecure', Proxmox.Utils.noneText + ' (' + gettext('insecure') + ')'],
> + ['insecure', gettext('None (insecure)')],
> ['starttls', 'STARTTLS'],
> ['tls', 'TLS'],
> ],
lgtm.
Reviewed-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-06-27 12:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-27 12:13 [pve-devel] [PATCH proxmox-widget-toolkit 1/3] fix #5588: notification: smtp: fix 'Authenticate' checkbox in Chromium Lukas Wagner
2025-06-27 12:13 ` [pve-devel] [PATCH proxmox-widget-toolkit 2/3] notification: smtp: only show 'Unchanged' in password field when it makes sense Lukas Wagner
2025-06-27 12:13 ` [pve-devel] [PATCH proxmox-widget-toolkit 3/3] notification: smtp: don't split translatable string Lukas Wagner
2025-06-27 12:22 ` Maximiliano Sandoval [this message]
2025-07-08 17:15 ` [pve-devel] [PATCH proxmox-widget-toolkit 1/3] fix #5588: notification: smtp: fix 'Authenticate' checkbox in Chromium Michael Köppl
2025-07-15 22:34 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s8objq9tlui.fsf@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox