public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [PATCH manager 0/7] ui: qga: add checkbox for guest-fsfreeze
Date: Wed, 25 Feb 2026 17:03:00 +0100	[thread overview]
Message-ID: <s8objhcg6a3.fsf@proxmox.com> (raw)
In-Reply-To: <20260225154614.681858-1-m.sandoval@proxmox.com> (Maximiliano Sandoval's message of "Wed, 25 Feb 2026 16:45:39 +0100")

Maximiliano Sandoval <m.sandoval@proxmox.com> writes:

> This was discussed off-list with Fiona.
>
> Something that was missing from Fiona's comments was giving the "hint" css class
> to the "Deprecated" part of the old checkbox's label. I was not sure how to make
> that work in extjs.
>
> The migration would work as follows:
>
>  - The new key takes preference over the old one so using the old one is OK.
>  - If the key is in the config file then the old checkbox would dbe displayed
>  - But delete the key from the config if the freeze is enabled, since it is the default

I forgot to mention here that the old key was moved to the advanced
options to prevent having two very similar rows together as it was
deemed to confusing.

-- 
Maximiliano




      parent reply	other threads:[~2026-02-25 16:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-25 15:45 Maximiliano Sandoval
2026-02-25 15:45 ` [PATCH manager 1/7] ui: utils: support guest-fsfreeze at render_qga_features Maximiliano Sandoval
2026-02-25 15:45 ` [PATCH manager 2/7] ui: qga: merge translatable string Maximiliano Sandoval
2026-02-25 15:45 ` [PATCH manager 3/7] ui: qga: move freeze-fs-on-backup to advanced opts Maximiliano Sandoval
2026-02-25 15:45 ` [PATCH manager 4/7] ui: qga: note that freeze-fs-on-backup is deprecated Maximiliano Sandoval
2026-02-25 15:45 ` [PATCH manager 5/7] ui: qga: add checkbox for guest-fsfreeze Maximiliano Sandoval
2026-02-25 15:45 ` [PATCH manager 6/7] ui: qga: call parameter me instead of this Maximiliano Sandoval
2026-02-25 15:45 ` [PATCH manager 7/7] ui: qga: hide freeze-fs-on-backup check if undefined Maximiliano Sandoval
2026-02-25 16:03 ` Maximiliano Sandoval [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s8objhcg6a3.fsf@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal