Re: [PATCH ha-manager] resources: Expand max_restart option

[Maximiliano Sandoval <m.sandoval@proxmox.com>]

Hannes Duerr <h.duerr@proxmox.com> writes:

> On 3/2/26 1:28 PM, Maximiliano Sandoval wrote:
>> When read next to `max_relocate` it is not clear which happens first
>> after a service fails to start.
>>
>> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
>> ---
>>
>> When writting I initially had "When reached, the service will be attempted to be
>> relocated" since it was clear it had to be on a "node" but as per HA rules not
>> all of them might be eligible or some of them might already have reached the
>> max_restart limit.
>>
>>   src/PVE/HA/Resources.pm | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/PVE/HA/Resources.pm b/src/PVE/HA/Resources.pm
>> index 68d9d16..66dd7b4 100644
>> --- a/src/PVE/HA/Resources.pm
>> +++ b/src/PVE/HA/Resources.pm
>> @@ -73,7 +73,8 @@ EODESC
>>           },
>>           max_restart => {
>>               description => "Maximal number of tries to restart the service on"
>> -                . " a node after its start failed.",
>> +                . " a node after its start failed. When reached, the service will be attempted to"
>> +                . " be relocated on an eligible node.",
> The phrasing is a bit too complicated, would the following make sense?
> `When reached, the HA manager will try to move the service to another eligible
> node.`

In such a case I would propose:

When reached, the HA manager will try to relocate the service on an eligible node.

Lets see if anyone has a preference.

>>               type => 'integer',
>>               optional => 1,
>>               default => 1,

-- 
Maximiliano