public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: superseded: [PATCH manager 1/1] ui: processor edit: allow setting 8 sockets
Date: Fri, 10 Jul 2026 10:44:51 +0200	[thread overview]
Message-ID: <s8o8q7jcjy4.fsf@toolbox> (raw)
In-Reply-To: <58aa3941-3f63-460a-99a8-c46e61b4a43d@proxmox.com> (Dominik Csapak's message of "Fri, 10 Jul 2026 10:19:15 +0200")

Dominik Csapak <d.csapak@proxmox.com> writes:

> On 7/10/26 10:06 AM, Maximiliano Sandoval wrote:
>> Dominik Csapak <d.csapak@proxmox.com> writes:
>> 
>>> On 7/10/26 9:42 AM, Maximiliano Sandoval wrote:
>>>> Dominik Csapak <d.csapak@proxmox.com> writes:
>>>>
>>>>> if the backend does not have an upper limit, shouldn't we use the same
>>>>> behavior in the frontend?
>>>> We have a hardcoded limit of $MAX_NUMA = 8 in qemu-server's Memory.pm as
>>>> mentioned by Alexandre in a reply to v1. I opted to be on the safer side
>>>> without redoing the entire numa handling.
>>>> At the moment there are systems with 8 sockets and at least one customer
>>>> asked for this in enterprise support.
>>>>
>>>
>>> but this is only tangentially related to the socket amount?
>>>
>>> i can boot a vm with e.g. 16 sockets + numa 1 boot perfectly fine?
>> In this case it is not possible to define numa policies via --numa0,
>> ..., --numa15 (they stop at --numa7).
>
> yes i get that, but this is an option that is
> 1. not exposed on the ui at all
> 2. has nothing to do with the number of sockets (inherently)
>
> for example:
> i can configure:
>
> sockets: 16
> cores: 1
> numa: 1
> memory: 1024
> numa0: cpus=0-7,memory=512
> numa1: cpus=8-15,memory=512
>
> and have 16 sockets but only 2 numa nodes...
>
>> When discussing this off-list with Fiona we decided to be on the safer
>> side, the number can be bumped again once 16 socket CPUs are more
>> common.
>
> this "breaks" the UI when a user sets higher values manually, as in, one
> cannot set any other option as long as the sockets are higher
>
> so im very much in favor of removing the maxValue at all...
>
>
>
>> 
>>>>> AFAICS two issues arise by having a lower value here than the
>>>>> backend: * we have to raise this (probably) again in the future * a
>>>>> config with a higher value cannot be edited in the gui (because it
>>>>> get's invalid)
>>>>>
>>>>> So i'd prefer just to remove the maxValue here completely.
>>>>>
>>>>> If there is any detrimental effect when having to much sockets
>>>>> configured, we could add a warning e.g. when the sockets
>>>>> is > 8.
>>>>
>> 

Superseded-by: https://lore.proxmox.com/all/20260710084423.164757-1-m.sandoval@proxmox.com/T/#u
-- 
Maximiliano




      reply	other threads:[~2026-07-10  8:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-06 11:47 [PATCH manager 1/1] ui: processor edit: allow setting 8 sockets Maximiliano Sandoval
2026-07-06 11:47 ` Maximiliano Sandoval
2026-07-09 14:30 ` Dominik Csapak
2026-07-10  7:42   ` Maximiliano Sandoval
2026-07-10  7:44     ` Dominik Csapak
2026-07-10  7:46       ` Dominik Csapak
2026-07-10  8:07       ` Maximiliano Sandoval
2026-07-10  8:19         ` Dominik Csapak
2026-07-10  8:44           ` Maximiliano Sandoval [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s8o8q7jcjy4.fsf@toolbox \
    --to=m.sandoval@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal