From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: Kefu Chai <k.chai@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: superseded: [PATCH manager 2/2] ceph: osd: stop running pveremove during cleanup
Date: Mon, 13 Jul 2026 09:05:12 +0200 [thread overview]
Message-ID: <s8o8q7f2wuv.fsf@toolbox> (raw)
In-Reply-To: <20260711050323.2573136-1-k.chai@proxmox.com> (Kefu Chai's message of "Sat, 11 Jul 2026 13:03:23 +0800")
Kefu Chai <k.chai@proxmox.com> writes:
> Verified: 7f007e7fc added api.remove_pv() to zap.py, so 'ceph-volume lvm
> zap --destroy' drops the PV itself. It is in every Ceph release available
> for PVE 9, so the pvremove here is redundant.
>
> Two nits: the message says Reef is the oldest supported Ceph in PVE 9,
> but per PVE/Ceph/Releases.pm that is Squid (19.2), Reef is PVE 8 only.
> Does not change the conclusion, 7f007e7fc is in Squid too. And the
> subject reads 'pveremove', which looks like a typo of 'pvremove'.
>
> Reviewed-by: Kefu Chai <k.chai@proxmox.com>
Thanks for the review.
Superseded-by: https://lore.proxmox.com/pve-devel/20260713070433.36620-1-m.sandoval@proxmox.com/T/#u
--
Maximiliano
next prev parent reply other threads:[~2026-07-13 7:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 12:33 [PATCH manager 0/2] ceph: osd: stop running pveremove during cleanup Maximiliano Sandoval
2026-03-17 12:33 ` [PATCH manager 1/2] ceph: osd: stop triggering udev Maximiliano Sandoval
2026-07-11 5:03 ` Kefu Chai
2026-03-17 12:33 ` [PATCH manager 2/2] ceph: osd: stop running pveremove during cleanup Maximiliano Sandoval
2026-03-18 12:19 ` Daniel Herzig
2026-07-11 5:03 ` Kefu Chai
2026-07-13 7:05 ` Maximiliano Sandoval [this message]
2026-07-06 8:46 ` [PATCH manager 0/2] " Maximiliano Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s8o8q7f2wuv.fsf@toolbox \
--to=m.sandoval@proxmox.com \
--cc=k.chai@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox