From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: Dominik Rusovac <d.rusovac@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH yew-mobile-gui 3/3] dashboard: polish CPU utilization presentation
Date: Wed, 18 Feb 2026 12:21:35 +0100 [thread overview]
Message-ID: <s8o4inei9fk.fsf@proxmox.com> (raw)
In-Reply-To: <20260218110333.158265-4-d.rusovac@proxmox.com> (Dominik Rusovac's message of "Wed, 18 Feb 2026 12:03:33 +0100")
Dominik Rusovac <d.rusovac@proxmox.com> writes:
> To align with the CPU utilization presentation in the web ui, this adds
> "CPU(s)" as the unit of the total number of CPUs displayed above to the
> right of the CPU utilization bar.
>
> Signed-off-by: Dominik Rusovac <d.rusovac@proxmox.com>
> ---
> src/pages/page_dashboard.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/pages/page_dashboard.rs b/src/pages/page_dashboard.rs
> index 93e0f83..9bd6141 100644
> --- a/src/pages/page_dashboard.rs
> +++ b/src/pages/page_dashboard.rs
> @@ -122,7 +122,7 @@ impl PvePageDashboard {
> tiles.push(
> icon_list_tile(Fa::new("cpu"), tr!("CPU"), (), ()).with_child(list_tile_usage(
> format!("{cpu_percentage:.2}%"),
> - maxcpu.to_string(),
> + format!("{maxcpu} CPU(s)"),
This should be translatable, see e.g.
https://lore.proxmox.com/all/20260128085614.91769-2-m.sandoval@proxmox.com/.
> cpu as f32,
> )),
> );
--
Maximiliano
next prev parent reply other threads:[~2026-02-18 11:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-18 11:03 [PATCH yew-mobile-gui 0/3] fix #7330: dashboard: display CPU utilization correctly Dominik Rusovac
2026-02-18 11:03 ` [PATCH yew-mobile-gui 1/3] run cargo fmt Dominik Rusovac
2026-02-18 11:03 ` [PATCH yew-mobile-gui 2/3] fix #7330: dashboard: display CPU utilization correctly Dominik Rusovac
2026-02-18 11:33 ` Dominik Csapak
2026-02-18 13:17 ` Dominik Rusovac
2026-02-18 11:03 ` [PATCH yew-mobile-gui 3/3] dashboard: polish CPU utilization presentation Dominik Rusovac
2026-02-18 11:21 ` Maximiliano Sandoval [this message]
2026-02-18 13:06 ` Dominik Rusovac
2026-02-19 12:11 ` superseded [PATCH yew-mobile-gui 0/3] fix #7330: dashboard: display CPU utilization correctly Dominik Rusovac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s8o4inei9fk.fsf@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=d.rusovac@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox