[pve-devel] [PATCH manager 1/2] api: nodes: index: specify the type of SSL certificate

[pve-devel] [PATCH manager 1/2] api: nodes: index: specify the type of SSL certificate

[Maximiliano Sandoval]

The function internally calls
PVE::Certificate::get_certificate_fingerprint which in turn calls:

```
    my $fp = Net::SSLeay::X509_get_fingerprint($cert, 'sha256');
```

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 PVE/API2/Nodes.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
index e8ff6dd9..1db148af 100644
--- a/PVE/API2/Nodes.pm
+++ b/PVE/API2/Nodes.pm
@@ -2567,7 +2567,7 @@ __PACKAGE__->register_method ({
 		    renderer => 'duration',
 		},
 		ssl_fingerprint => {
-		    description => "The SSL fingerprint for the node certificate.",
+		    description => "The SSL SHA-256 fingerprint for the node certificate.",
 		    type => 'string',
 		    optional => 1,
 		},
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager 2/2] api: node: index: use standard fingerprint-sha256 option

[Maximiliano Sandoval]

This adds a regex check for valid fingerprints.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---

Diferences from v1:
 - Use get_standard_option

 PVE/API2/Nodes.pm | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
index 1db148af..8dddf58b 100644
--- a/PVE/API2/Nodes.pm
+++ b/PVE/API2/Nodes.pm
@@ -2566,11 +2566,10 @@ __PACKAGE__->register_method ({
 		    optional => 1,
 		    renderer => 'duration',
 		},
-		ssl_fingerprint => {
+		ssl_fingerprint => get_standard_option('fingerprint-sha256', {
 		    description => "The SSL SHA-256 fingerprint for the node certificate.",
-		    type => 'string',
 		    optional => 1,
-		},
+		}),
 	    },
 	},
 	links => [ { rel => 'child', href => "{node}" } ],
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager 2/2] api: node: index: use standard fingerprint-sha256 option

[Maximiliano Sandoval]

Maximiliano Sandoval <m.sandoval@proxmox.com> writes:

I forgot to mark this as v2.

> This adds a regex check for valid fingerprints.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel