From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH] webhook edit: do not split translatable strings
Date: Mon, 02 Dec 2024 14:24:19 +0100 [thread overview]
Message-ID: <s8o1pyqp69o.fsf@proxmox.com> (raw)
In-Reply-To: <D5RXTA3OPIVP.DFCWVRI9IYW8@proxmox.com> (Shannon Sterz's message of "Thu, 21 Nov 2024 15:47:32 +0100")
"Shannon Sterz" <s.sterz@proxmox.com> writes:
> wouldn't it be more elegant to simply define `addLabel` as
> `gettext('Add')` and then override that where needed? that would safe
> this akward ternary operator. haven't tested that though.
Not sure to be honest. Whenever in doubt I try to leave the logic as
close as possible to the original. If anyone feels somewhat strongly
about this I can make a v2.
--
Maximiliano
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-12-02 13:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-21 14:28 Maximiliano Sandoval
2024-11-21 14:47 ` Shannon Sterz
2024-12-02 13:24 ` Maximiliano Sandoval [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s8o1pyqp69o.fsf@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox