From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: [pve-devel] applied: [PATCH qemu-server] live import: correctly generate blockdev
Date: Mon, 25 Aug 2025 12:08:10 +0200 [thread overview]
Message-ID: <s5eyaumkhmd4natwkypdvivvrabdrft4m2vp4tdz6bga25rpmv@u44mqdwahrnn> (raw)
In-Reply-To: <20250814130625.267960-1-f.ebner@proxmox.com>
applied, thanks
On Thu, Aug 14, 2025 at 03:06:00PM +0200, Fiona Ebner wrote:
> The throttle node is generated later above the alloc-track block node,
> so generating the alloc-track backing block node needs to happen with
> 'no-throttle' to avoid a duplicate node name and avoid an additional
> throttle node in the graph.
>
> Reported in the community forum:
> https://forum.proxmox.com/threads/169766/
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> src/PVE/QemuServer.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
> index 78cfad62..f263fedb 100644
> --- a/src/PVE/QemuServer.pm
> +++ b/src/PVE/QemuServer.pm
> @@ -7379,7 +7379,7 @@ sub live_import_from_files {
> my ($interface, $index) = PVE::QemuServer::Drive::parse_drive_interface($dev);
> my $drive = { file => $volid, interface => $interface, index => $index };
> my $blockdev = PVE::QemuServer::Blockdev::generate_drive_blockdev(
> - $storecfg, $drive, $machine_version, {},
> + $storecfg, $drive, $machine_version, { 'no-throttle' => 1 },
> );
> $live_restore_backing->{$dev}->{blockdev} = $blockdev;
> } else {
> --
> 2.47.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-08-25 10:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 13:06 [pve-devel] " Fiona Ebner
2025-08-25 10:08 ` Wolfgang Bumiller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5eyaumkhmd4natwkypdvivvrabdrft4m2vp4tdz6bga25rpmv@u44mqdwahrnn \
--to=w.bumiller@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox