* [pve-devel] [PATCH container 1/1] fix #5538: network: enable accept_ra for DHCPv6 configurations [not found] <20251111071450.10188-1-alex@goodkind.io> @ 2025-11-11 7:14 ` Alex Goodkind via pve-devel 2025-11-11 11:50 ` Gabriel Goller 2025-11-12 7:57 ` [pve-devel] applied: " Thomas Lamprecht [not found] ` <20251111071450.10188-2-alex@goodkind.io> 1 sibling, 2 replies; 8+ messages in thread From: Alex Goodkind via pve-devel @ 2025-11-11 7:14 UTC (permalink / raw) To: pve-devel; +Cc: Alex Goodkind, tarick [-- Attachment #1: Type: message/rfc822, Size: 6338 bytes --] From: Alex Goodkind <alex@goodkind.io> To: pve-devel@lists.proxmox.com Cc: tarick@bedeir.com, Alex Goodkind <alex@goodkind.io> Subject: [PATCH container 1/1] fix #5538: network: enable accept_ra for DHCPv6 configurations Date: Mon, 10 Nov 2025 23:14:50 -0800 Message-ID: <20251111071450.10188-2-alex@goodkind.io> DHCPv6 requires Router Advertisements to function as specified in the IPv6 standard. Previously, accept_ra was only enabled for 'auto' mode, causing DHCPv6 configurations to fail when RAs were needed. Enable accept_ra for both 'auto' and 'dhcp' IPv6 modes. Signed-off-by: Alex Goodkind <alex@goodkind.io> --- src/PVE/LXC/Setup/Base.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PVE/LXC/Setup/Base.pm b/src/PVE/LXC/Setup/Base.pm index a2c88ed..bb4a12b 100644 --- a/src/PVE/LXC/Setup/Base.pm +++ b/src/PVE/LXC/Setup/Base.pm @@ -296,6 +296,7 @@ DATA if (defined(my $ip = $d->{ip6})) { if ($ip eq 'dhcp') { $dhcp |= $DHCP6; + $accept_ra = 'true'; } elsif ($ip eq 'auto') { $accept_ra = 'true'; } elsif ($ip ne 'manual') { -- 2.43.0 [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [pve-devel] [PATCH container 1/1] fix #5538: network: enable accept_ra for DHCPv6 configurations 2025-11-11 7:14 ` [pve-devel] [PATCH container 1/1] fix #5538: network: enable accept_ra for DHCPv6 configurations Alex Goodkind via pve-devel @ 2025-11-11 11:50 ` Gabriel Goller 2025-11-12 7:57 ` [pve-devel] applied: " Thomas Lamprecht 1 sibling, 0 replies; 8+ messages in thread From: Gabriel Goller @ 2025-11-11 11:50 UTC (permalink / raw) To: Proxmox VE development discussion; +Cc: Alex Goodkind, tarick LGTM! Consider: Tested-by: Gabriel Goller <g.goller@proxmox.com> Reviewed-by: Gabriel Goller <g.goller@proxmox.com> Interesting detail I wasn't aware of: systemd-networkd always disables the kernel's IPv6 Router Advertisement handling (by setting accept_ra=0) because it implements its own userspace Router Advertisement handler. :) _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* [pve-devel] applied: [PATCH container 1/1] fix #5538: network: enable accept_ra for DHCPv6 configurations 2025-11-11 7:14 ` [pve-devel] [PATCH container 1/1] fix #5538: network: enable accept_ra for DHCPv6 configurations Alex Goodkind via pve-devel 2025-11-11 11:50 ` Gabriel Goller @ 2025-11-12 7:57 ` Thomas Lamprecht 1 sibling, 0 replies; 8+ messages in thread From: Thomas Lamprecht @ 2025-11-12 7:57 UTC (permalink / raw) To: pve-devel; +Cc: Alex Goodkind, tarick On Mon, 10 Nov 2025 23:14:50 -0800, Alex Goodkind via pve-devel wrote: > DHCPv6 requires Router Advertisements to function as specified in > the IPv6 standard. Previously, accept_ra was only enabled for 'auto' > mode, causing DHCPv6 configurations to fail when RAs were needed. > > Enable accept_ra for both 'auto' and 'dhcp' IPv6 modes. > > > [...] Applied, thanks! [1/1] fix #5538: network: enable accept_ra for DHCPv6 configurations commit: 8bc37cfbb1237cba4d0e1adf8188195f2945c9a0 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <20251111071450.10188-2-alex@goodkind.io>]
* Re: [pve-devel] [PATCH container 1/1] fix #5538: network: enable accept_ra for DHCPv6 configurations [not found] ` <20251111071450.10188-2-alex@goodkind.io> @ 2025-11-11 15:46 ` Thomas Lamprecht 2025-11-11 17:02 ` Alex Goodkind via pve-devel [not found] ` <CAAbO5hZ4SzcQRivyJC7tompikRMESgE+FJincNX7hryjY2TyHA@mail.gmail.com> 0 siblings, 2 replies; 8+ messages in thread From: Thomas Lamprecht @ 2025-11-11 15:46 UTC (permalink / raw) To: Alex Goodkind, pve-devel; +Cc: tarick Am 11.11.25 um 08:14 schrieb Alex Goodkind: > DHCPv6 requires Router Advertisements to function as specified in > the IPv6 standard. Previously, accept_ra was only enabled for 'auto' > mode, causing DHCPv6 configurations to fail when RAs were needed. > > Enable accept_ra for both 'auto' and 'dhcp' IPv6 modes. > Many thanks for your patch, looks alright. Would you mind sending in a signed CLA [0] for this? I know the change itself is relatively trivial, but we rather want to stay on the safe side here. [0]: https://pve.proxmox.com/wiki/Developer_Documentation#Software_License_and_Copyright _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [pve-devel] [PATCH container 1/1] fix #5538: network: enable accept_ra for DHCPv6 configurations 2025-11-11 15:46 ` [pve-devel] " Thomas Lamprecht @ 2025-11-11 17:02 ` Alex Goodkind via pve-devel [not found] ` <CAAbO5hZ4SzcQRivyJC7tompikRMESgE+FJincNX7hryjY2TyHA@mail.gmail.com> 1 sibling, 0 replies; 8+ messages in thread From: Alex Goodkind via pve-devel @ 2025-11-11 17:02 UTC (permalink / raw) To: Thomas Lamprecht; +Cc: Alex Goodkind, pve-devel, tarick [-- Attachment #1: Type: message/rfc822, Size: 6096 bytes --] From: Alex Goodkind <alex@goodkind.io> To: Thomas Lamprecht <t.lamprecht@proxmox.com> Cc: pve-devel@lists.proxmox.com, tarick@bedeir.com Subject: Re: [PATCH container 1/1] fix #5538: network: enable accept_ra for DHCPv6 configurations Date: Tue, 11 Nov 2025 09:02:06 -0800 Message-ID: <CAAbO5hZ4SzcQRivyJC7tompikRMESgE+FJincNX7hryjY2TyHA@mail.gmail.com> No problem, just sent the signed individual CLA to office@proxmox.com On Tue, Nov 11, 2025 at 07:46 Thomas Lamprecht <t.lamprecht@proxmox.com> wrote: > Am 11.11.25 um 08:14 schrieb Alex Goodkind: > > DHCPv6 requires Router Advertisements to function as specified in > > the IPv6 standard. Previously, accept_ra was only enabled for 'auto' > > mode, causing DHCPv6 configurations to fail when RAs were needed. > > > > Enable accept_ra for both 'auto' and 'dhcp' IPv6 modes. > > > > Many thanks for your patch, looks alright. > > Would you mind sending in a signed CLA [0] for this? I know the change > itself > is relatively trivial, but we rather want to stay on the safe side here. > > [0]: > https://pve.proxmox.com/wiki/Developer_Documentation#Software_License_and_Copyright > > > > [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <CAAbO5hZ4SzcQRivyJC7tompikRMESgE+FJincNX7hryjY2TyHA@mail.gmail.com>]
* Re: [pve-devel] [PATCH container 1/1] fix #5538: network: enable accept_ra for DHCPv6 configurations [not found] ` <CAAbO5hZ4SzcQRivyJC7tompikRMESgE+FJincNX7hryjY2TyHA@mail.gmail.com> @ 2025-11-12 1:55 ` Alex Goodkind via pve-devel 2025-11-13 13:05 ` Gabriel Goller 0 siblings, 1 reply; 8+ messages in thread From: Alex Goodkind via pve-devel @ 2025-11-12 1:55 UTC (permalink / raw) To: Thomas Lamprecht; +Cc: Alex Goodkind, pve-devel, tarick [-- Attachment #1: Type: message/rfc822, Size: 6146 bytes --] From: Alex Goodkind <alex@goodkind.io> To: Thomas Lamprecht <t.lamprecht@proxmox.com> Cc: pve-devel@lists.proxmox.com, tarick@bedeir.com Subject: Re: [PATCH container 1/1] fix #5538: network: enable accept_ra for DHCPv6 configurations Date: Tue, 11 Nov 2025 17:55:33 -0800 Message-ID: <CAAbO5hapcJjpJ-tzEY+HtuX--fJsdcr0DWOBMpUq3MzcDmzZ_w@mail.gmail.com> What happens from here in terms of getting this merged? On Tue, Nov 11, 2025 at 09:02 Alex Goodkind <alex@goodkind.io> wrote: > No problem, just sent the signed individual CLA to office@proxmox.com > > On Tue, Nov 11, 2025 at 07:46 Thomas Lamprecht <t.lamprecht@proxmox.com> > wrote: > >> Am 11.11.25 um 08:14 schrieb Alex Goodkind: >> > DHCPv6 requires Router Advertisements to function as specified in >> > the IPv6 standard. Previously, accept_ra was only enabled for 'auto' >> > mode, causing DHCPv6 configurations to fail when RAs were needed. >> > >> > Enable accept_ra for both 'auto' and 'dhcp' IPv6 modes. >> > >> >> Many thanks for your patch, looks alright. >> >> Would you mind sending in a signed CLA [0] for this? I know the change >> itself >> is relatively trivial, but we rather want to stay on the safe side here. >> >> [0]: >> https://pve.proxmox.com/wiki/Developer_Documentation#Software_License_and_Copyright >> >> >> >> [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [pve-devel] [PATCH container 1/1] fix #5538: network: enable accept_ra for DHCPv6 configurations 2025-11-12 1:55 ` Alex Goodkind via pve-devel @ 2025-11-13 13:05 ` Gabriel Goller 2025-11-13 14:40 ` Alex Goodkind via pve-devel 0 siblings, 1 reply; 8+ messages in thread From: Gabriel Goller @ 2025-11-13 13:05 UTC (permalink / raw) To: Proxmox VE development discussion; +Cc: tarick, Thomas Lamprecht, Alex Goodkind On 11.11.2025 17:55, Alex Goodkind via pve-devel wrote: > What happens from here in terms of getting this merged? This has already been merged: https://git.proxmox.com/?p=pve-container.git;a=commit;h=8bc37cfbb1237cba4d0e1adf8188195f2945c9a0 This means it will be included in the next point-release! _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [pve-devel] [PATCH container 1/1] fix #5538: network: enable accept_ra for DHCPv6 configurations 2025-11-13 13:05 ` Gabriel Goller @ 2025-11-13 14:40 ` Alex Goodkind via pve-devel 0 siblings, 0 replies; 8+ messages in thread From: Alex Goodkind via pve-devel @ 2025-11-13 14:40 UTC (permalink / raw) To: Proxmox VE development discussion, Thomas Lamprecht, Alex Goodkind, tarick Cc: Alex Goodkind [-- Attachment #1: Type: message/rfc822, Size: 5801 bytes --] From: Alex Goodkind <alex@goodkind.io> To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Thomas Lamprecht <t.lamprecht@proxmox.com>, Alex Goodkind <alex@goodkind.io>, tarick@bedeir.com Subject: Re: [pve-devel] [PATCH container 1/1] fix #5538: network: enable accept_ra for DHCPv6 configurations Date: Thu, 13 Nov 2025 06:40:30 -0800 Message-ID: <CAAbO5hayVdHcJdM8BXWmiqRp9p1K9poVRS+Mzfw0VGKadZ+FnQ@mail.gmail.com> Awesome! On Thu, Nov 13, 2025 at 05:05 Gabriel Goller <g.goller@proxmox.com> wrote: > On 11.11.2025 17:55, Alex Goodkind via pve-devel wrote: > > What happens from here in terms of getting this merged? > > This has already been merged: > > https://git.proxmox.com/?p=pve-container.git;a=commit;h=8bc37cfbb1237cba4d0e1adf8188195f2945c9a0 > > This means it will be included in the next point-release! > > > [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2025-11-13 14:39 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20251111071450.10188-1-alex@goodkind.io>
2025-11-11 7:14 ` [pve-devel] [PATCH container 1/1] fix #5538: network: enable accept_ra for DHCPv6 configurations Alex Goodkind via pve-devel
2025-11-11 11:50 ` Gabriel Goller
2025-11-12 7:57 ` [pve-devel] applied: " Thomas Lamprecht
[not found] ` <20251111071450.10188-2-alex@goodkind.io>
2025-11-11 15:46 ` [pve-devel] " Thomas Lamprecht
2025-11-11 17:02 ` Alex Goodkind via pve-devel
[not found] ` <CAAbO5hZ4SzcQRivyJC7tompikRMESgE+FJincNX7hryjY2TyHA@mail.gmail.com>
2025-11-12 1:55 ` Alex Goodkind via pve-devel
2025-11-13 13:05 ` Gabriel Goller
2025-11-13 14:40 ` Alex Goodkind via pve-devel
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox