Re: [PATCH pve-manager v8 21/21] sdn: add dry-run diff view for sdn apply

[Gabriel Goller <g.goller@proxmox.com>]

On 28.03.2026 21:19, Thomas Lamprecht wrote:
> Am 27.03.26 um 16:01 schrieb Gabriel Goller:
> > Introduce a new SdnDiffView modal that runs a dry-run and shows the frr
> > and ifupdown2 configuration changes which will be made when clicking
> > apply. Now the user knows which config options will be set without
> > needing to apply the config.
> 
> This is not really a ideal (modern) ExtJS component implementation, i.e.
> could be more declarative, and has some smaller UX issues, like scrolling
> the whole view, not the two panels that can actually get taller separately.
> 
> We also might want to load this for all nodes, as with more than a handful
> of nodes this becomes rather very annoying to cross-check.  But that we
> can still do/extend later just fine, so no hard feelings here for now.

Yep agree, especially when creating per-node components such as the bgp
controller this could be useful.


> My reimplementation that's still relatively close to yours semantically:
> 
> Ext.define('PVE.sdn.SdnDiffView', {
>     extend: 'Ext.window.Window',
> 
>     width: 800,
>     height: 900,
> [snip]

I'll test your component and send it as a patch tommorow.
Then we'll have a look at a multi-node view in the future.

Thanks!