Re: [pve-devel] [PATCH pve-cluster v2 3/3] Create temporary CSR file in /run instead of /tmp

[Arthur Bied-Charreton <a.bied-charreton@proxmox.com>]

On Tue, Mar 17, 2026 at 02:57:21PM +0100, Maximiliano Sandoval wrote:
> Arthur Bied-Charreton <a.bied-charreton@proxmox.com> writes:
> 
> > Creating temp files in a world-writable directory such as /tmp could expose 
> > the config generation to symlink races. Use /run directory instead.
> >
> > As suggested here:
> > https://lore.proxmox.com/pve-devel/20260123195300.0ae7fcc9@rosa.proxmox.com/T/#t
> >
> > Suggested-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> > Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
> > ---
> >  src/PVE/Cluster/Setup.pm | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/PVE/Cluster/Setup.pm b/src/PVE/Cluster/Setup.pm
> > index b9cacfd..5ed85ad 100644
> > --- a/src/PVE/Cluster/Setup.pm
> > +++ b/src/PVE/Cluster/Setup.pm
> > @@ -504,7 +504,7 @@ sub gen_pve_ssl_cert {
> >          $names .= ",DNS:$fqdn";
> >      }
> >  
> > -    my $reqfn = "/tmp/pvecertreq-$$.tmp";
> > +    my $reqfn = "/run/pvecertreq-$$.tmp";
> 
> Note that the cluster filesystem already creates a RUNDIR owned by
> root:www-data with 710 permissions under /run/pve-cluster.
> 
> Perhaps that is more appropriate?
Did not know about this, thanks! Sent a v3:
https://lore.proxmox.com/pve-devel/20260317142206.482976-1-a.bied-charreton@proxmox.com/T/#u
> 
> NOTE: It is a bit odd that in the pmxcfs.c there is an explicit call
> mkdir(RUNDIR, 0755), but in practice it appears as 710.
> 
> >      unlink $reqfn;
> >  
> >      my $pvessl_key_fn = "$pmxcfs_base_dir/nodes/$nodename/pve-ssl.key";
> 
> -- 
> Maximiliano