From: Gabriel Goller <g.goller@proxmox.com>
To: Daniel Kral <d.kral@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [RFC PATCH] frr: d/control: add proxmox-frr-templates dependency
Date: Tue, 31 Mar 2026 11:15:59 +0200 [thread overview]
Message-ID: <r7ndd2qg6idxlndosylac75ngkphc36x5pbqmuo4me2enymfgt@cmiijv5zaeqz> (raw)
In-Reply-To: <20260331090050.128253-1-d.kral@proxmox.com>
On 31.03.2026 11:00, Daniel Kral wrote:
> proxmox-frr requires the jinja template files provided by
> proxmox-frr-templates at compile time to build the crate.
>
> Signed-off-by: Daniel Kral <d.kral@proxmox.com>
> ---
> I've stumbled on this when the build for libpve-rs-perl failed because I
> didn't have the package installed.
>
> proxmox-frr/debian/control | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/proxmox-frr/debian/control b/proxmox-frr/debian/control
> index 265fa70..e918000 100644
> --- a/proxmox-frr/debian/control
> +++ b/proxmox-frr/debian/control
> @@ -18,7 +18,8 @@ Build-Depends-Arch: cargo:native <!nocheck>,
> librust-serde-1+derive-dev <!nocheck>,
> librust-serde-repr-0.1+default-dev <!nocheck>,
> librust-thiserror-2+default-dev <!nocheck>,
> - librust-tracing-0.1+default-dev <!nocheck>
> + librust-tracing-0.1+default-dev <!nocheck>,
> + proxmox-frr-templates <!nocheck>
> Maintainer: Proxmox Support Team <support@proxmox.com>
> Standards-Version: 4.7.2
> Vcs-Git: git://git.proxmox.com/git/proxmox-ve-rs.git
> @@ -43,7 +44,8 @@ Depends:
> librust-serde-1+derive-dev,
> librust-serde-repr-0.1+default-dev,
> librust-thiserror-2+default-dev,
> - librust-tracing-0.1+default-dev
> + librust-tracing-0.1+default-dev,
> + proxmox-frr-templates
> Provides:
> librust-proxmox-frr+default-dev (= ${binary:Version}),
> librust-proxmox-frr-0-dev (= ${binary:Version}),
> --
> 2.47.3
Arghh, I had this at some point but it slipped out. Sorry about that!
LGTM, Consider:
Reviewed-by: Gabriel Goller <g.goller@proxmox.com>
prev parent reply other threads:[~2026-03-31 9:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 9:00 Daniel Kral
2026-03-31 9:15 ` Gabriel Goller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=r7ndd2qg6idxlndosylac75ngkphc36x5pbqmuo4me2enymfgt@cmiijv5zaeqz \
--to=g.goller@proxmox.com \
--cc=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox