Re: [pve-devel] [PATCH installer v2 0/7] gui: use gtk grids when possible

[Christoph Heiss <c.heiss@proxmox.com>]

LGTM. Tested this using latest master + ISO base. Keyboard shortcuts
also work as before.

Please consider it:

Tested-by: Christoph Heiss <c.heiss@proxmox.com>
Reviewed-by: Christoph Heiss <c.heiss@proxmox.com>

On Tue, Nov 21, 2023 at 04:10:18PM +0100, Maximiliano Sandoval wrote:
>
> We replace the use of nested boxes with grids when possible to ensure correct
> margins and alignment of widgets.
>
> At the end we also remove trailing spaces and colons from labels preceding an
> input widget, e.g. we replace `DNS Server: ` with `DNS Server`.
>
> Differences from v1:
>   - Rebased on top of master
>
> Maximiliano Sandoval (7):
>   gui: move create_basic_grid subroutine definition up
>   gui: expand ip address Gtk3::Entry
>   gui: use basic grid in password panel
>   gui: use basic grid in country/timezone panel
>   gui: change margins in create_basic_grid
>   gui: use basic grid in the network panel
>   gui: remove trailing spaces and colons
>
>  proxinstall | 153 +++++++++++++++++++++++-----------------------------
>  1 file changed, 66 insertions(+), 87 deletions(-)
>
> --
> 2.39.2
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>