public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Gabriel Goller <g.goller@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 1/2] lxc: show dynamically assigned IPs in network tab
Date: Wed, 4 Dec 2024 11:45:41 +0100	[thread overview]
Message-ID: <q3la3ygz6l7dbm76lfmaekzi5g4hmgwezd7d4cu3eepczj7wbo@4dg6dbyi6vgs> (raw)
In-Reply-To: <c05b655f-c54f-43c0-b738-72fa090fecf8@proxmox.com>

On 04.12.2024 11:10, Dominik Csapak wrote:
>On 12/4/24 10:52, Gabriel Goller wrote:
>>On 04.12.2024 10:17, Dominik Csapak wrote:
>>>generally looks good but i have one high level comment/question
>>>(and some nits inline)
>>>
>>>one thing i'd like to see here is to retain the info what is configured,
>>>so previously the info was either 'dhcp'/'auto' (slaac) or an ip address
>>>
>>>now we only show the ip adress
>>>
>>>what i mean is something like
>>>
>>>'x.y.z.w (dhcp)'
>>>
>>>or
>>>
>>>'xx00::1 (static)'
>>>
>>>etc. so one can still see what mode is configured
>>
>>This is a nice idea, but it could be a bit tricky. To get the ip info we
>>execute `ip a` in the container's netns, but for some reason I can't see
>>the 'dynamic' option which is usually shown on a dynamically acquired
>>address.
>>I could use `ip route` and check if the route was inserted by 'dhcp' or
>>'kernel', but no idea how foolproof this is...
>>
>
>but you should have the info what is configured from the confResponse, no?
>
>so something like
>
>
>if (net.ip === 'dhcp' || ...) {
>net.ip = `${iface.inet} (${net.ip})`;
>...
>}
>
>?

Oh, yeah didn't notice this, this is nice.
Though I still have to change the api endpoint to return multiple
ip-addresses so that we also support a static ip with a dhcp-enabled
bridge (this will set two addresses on the interface). Then I can match
the static ip from the config with the set ip and find out which one is
static and which one is dynamic.
Thanks!



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2024-12-04 10:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-02 10:46 [pve-devel] [PATCH manager 0/2] Show container ip in summary and " Gabriel Goller
2024-12-02 10:46 ` [pve-devel] [PATCH manager 1/2] lxc: show dynamically assigned IPs in " Gabriel Goller
2024-12-04  9:17   ` Dominik Csapak
2024-12-04  9:52     ` Gabriel Goller
2024-12-04 10:10       ` Dominik Csapak
2024-12-04 10:45         ` Gabriel Goller [this message]
2024-12-02 10:46 ` [pve-devel] [PATCH manager 2/2] lxc: show IPs in summary view Gabriel Goller
2024-12-04  9:25   ` Dominik Csapak
2024-12-05 17:28     ` Gabriel Goller
2024-12-06 12:45       ` Dominik Csapak
2024-12-06  9:44     ` Gabriel Goller
2024-12-10 15:08 ` [pve-devel] [PATCH manager 0/2] Show container ip in summary and network tab Gabriel Goller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=q3la3ygz6l7dbm76lfmaekzi5g4hmgwezd7d4cu3eepczj7wbo@4dg6dbyi6vgs \
    --to=g.goller@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal