Re: [pve-devel] [PATCH v2 00/22] add automated/unattended installation

[Christoph Heiss <c.heiss@proxmox.com>]

On Wed, Feb 21, 2024 at 12:07:43PM +0100, Aaron Lauterer wrote:
> This patch series adds the possibility to do an automated / unattended
> installation of Proxmox VE.
>
[..]

Before anyone else stumbles into this while testing/reviewing, I've also
just talked with Aaron over this: Basically, the build is a bit racy and
can fail to due a missing prerequisite in the Makefile.

The proper fix boils down to:

diff --git a/Makefile b/Makefile
index dec5b7b..89b4cbb 100644
--- a/Makefile
+++ b/Makefile
@@ -99,7 +99,7 @@ VARLIBDIR=$(DESTDIR)/var/lib/proxmox-installer
 HTMLDIR=$(VARLIBDIR)/html/common

 .PHONY: install
-install: $(INSTALLER_SOURCES) $(CARGO_COMPILEDIR)/proxmox-tui-installer
+install: $(INSTALLER_SOURCES) $(COMPILED_BINS)
 	$(MAKE) -C banner install
 	$(MAKE) -C Proxmox install
 	install -D -m 644 interfaces $(DESTDIR)/etc/network/interfaces
@@ -118,7 +118,11 @@ install: $(INSTALLER_SOURCES) $(CARGO_COMPILEDIR)/proxmox-tui-installer
 $(COMPILED_BINS): cargo-build
 .PHONY: cargo-build
 cargo-build:
-	$(CARGO) build --package proxmox-tui-installer --bin proxmox-tui-installer $(CARGO_BUILD_ARGS)
+	$(CARGO) build \
+		--package proxmox-tui-installer --bin proxmox-tui-installer \
+		--package proxmox-auto-installer --bin proxmox-tui-installer \
+			--bin proxmox-autoinst-helper --bin proxmox-fetch-answer \
+		$(CARGO_BUILD_ARGS)

 %-banner.png: %-banner.svg
 	rsvg-convert -o $@ $<