public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
To: Stefan Hanreich <s.hanreich@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH docs/manager/network/proxmox{,-ve-rs,-perl-rs} v2 00/11] Status reporting for WireGuard fabrics
Date: Wed, 18 Nov 2026 16:20:29 +0100	[thread overview]
Message-ID: <p4hko6zi3azfu2a2oavzf5wiblircmx6ilbv6l72nw755cyent@mciaukf53uoo> (raw)
In-Reply-To: <20261117183500.750636-1-s.hanreich@proxmox.com>

On Tue, Nov 17, 2026 at 07:34:47PM +0100, Stefan Hanreich wrote:
> ## Introduction
> 
> This patch series adds status reporting for WireGuard fabrics to pvestatd and
> exposes additional information about WireGuard interfaces and neighbors (=
> peers) via the pre-existing interface/neighbors endpoints for fabrics.
> 
> 
[snip]
> ## Open questions
>
> The return schema of the neighbor status endpoint had some non-optional strings.
> This series makes 'uptime' optional, since it is not returned for the WireGuard
> fabric, as well as 'neighbor', since the endpoint of a WireGuard peer is not
> known before the first handshake if it has none configured. Initially, I
> returned hard-coded strings for those fields for the WireGuard fabric, but
> decided to omit them instead, since they could be potentially misleading and
> don't really add anything. Still a bit unsure about this, since it is
> technically a breaking API change. It should be easy to just add this in a new
> iteration again - even if only 'n/a' or something similar is returned for the
> non-optional fields.
fwiw i think omitting them is fine, returning a placeholder would be
more confusing IMO. 

[snip]

setup: 3-node mesh WG fabric

tested the following cases:
- neighbors are 'idle' without traffic with persistent-keepalive disabled
- traffic between node & neighbor changes neighbor status to 'active'
- neighbor drops back to 'idle' after some inactivity
- all neighbors become 'active' after setting persistent keepalive (25s)
- cutting a neighbor off drops it to 'down', re-allowing traffic sets it
  back to 'active'
- setting the wg0 link to down on a node reports it as 'down' and the 
  whole fabric as 'not ok' on that node
- deleting wg0 altogether shows it as 'missing', the whole fabric as
  'not ok' on that node
- adding another dummy link called wg0 shows it as 'error', the whole
  fabric as 'not ok' on that node
- removing a neighbor (wg set wg0 peer ... remove) reports the fabric as
  'not ok' on that node
- an extra peer that is not in the config appears in the neighbors list,
  fabric is shown as 'not ok' on that node
- removing the wg executable shows the fabric as 'not ok' on that node

just one question: would it make sense to log `wg show` failures
somehow? currently the fabric is just shown as 'not ok' but one does 
not see why anywhere. might be a bit spammy though since this is 
called regularly by pvestatd, but maybe it would be possible to only 
log on state changes? 

besides that i haven't run into any unexpected behavior while testing, 
therefore consider this series:

Tested-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com> 




      parent reply	other threads:[~2026-11-18 15:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 18:34 [PATCH docs/manager/network/proxmox{,-ve-rs,-perl-rs} v2 00/11] Status reporting for WireGuard fabrics Stefan Hanreich
2026-11-17 18:34 ` [PATCH proxmox v2 01/11] network-api: add missing getters Stefan Hanreich
2026-11-17 18:34 ` [PATCH proxmox v2 02/11] network-api: add support for parsing interface flags Stefan Hanreich
2026-11-17 18:34 ` [PATCH proxmox v2 03/11] wireguard: derive additional traits for public key Stefan Hanreich
2026-11-17 18:34 ` [PATCH proxmox-ve-rs v2 04/11] ve-config: sdn: wireguard: add getters for interface listen port and " Stefan Hanreich
2026-11-17 18:34 ` [PATCH proxmox-ve-rs v2 05/11] ve-config: sdn: wireguard: add helper for resolving the peers of an interface Stefan Hanreich
2026-11-17 18:34 ` [PATCH proxmox-perl-rs v2 06/11] sdn status: fabrics: add status reporting for wireguard Stefan Hanreich
2026-11-17 18:34 ` [PATCH proxmox-perl-rs v2 07/11] sdn status: fabrics: check interfaces and peers for wireguard status Stefan Hanreich
2026-11-17 18:34 ` [PATCH proxmox-perl-rs v2 08/11] sdn status: fabrics: report status of wireguard neighbors Stefan Hanreich
2026-11-17 18:34 ` [PATCH pve-network v2 09/11] api: fabric status: add schema for wireguard properties Stefan Hanreich
2026-11-17 18:34 ` [PATCH pve-manager v2 10/11] ui: fabric content: add wireguard protocol Stefan Hanreich
2026-11-17 18:34 ` [PATCH pve-docs v2 11/11] sdn: add documentation for wireguard status reporting Stefan Hanreich
2026-11-18 15:20 ` Arthur Bied-Charreton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=p4hko6zi3azfu2a2oavzf5wiblircmx6ilbv6l72nw755cyent@mciaukf53uoo \
    --to=a.bied-charreton@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.hanreich@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal