From: Gabriel Goller <g.goller@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH network v2] sdn: write frr config if the frr.conf.local file exists
Date: Tue, 18 Nov 2025 13:35:18 +0100 [thread overview]
Message-ID: <p2qcb7fj2gqxrycb4auahblbiayvx24e25tnvju2iz3bsrfc62@fowy4uuvw573> (raw)
In-Reply-To: <176346828818.1130134.8892090311116744465.b4-ty@proxmox.com>
On 18.11.2025 13:18, Thomas Lamprecht wrote:
> On Thu, 02 Oct 2025 15:09:49 +0200, Gabriel Goller wrote:
> > Currently we check if there is a fabric or a controller existing to
> > decide if we write the frr.conf file. Also add a check if the
> > frr.conf.local exists. This way it's possible to have a custom config in
> > the frr.conf.local file without any SDN objects configured and still
> > be able to apply the config.
> > By not checking the content we can also clear the frr config by clearing
> > the frr.conf.local file.
> >
> > [...]
>
> Applied, with small code clean-up as follow-up (please recheck!), thanks!
>
> [1/1] sdn: write frr config if the frr.conf.local file exists
> commit: 76ce7859e66e2709f895157154005607adce5004
LGTM!
thanks for applying!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-11-18 12:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-02 13:09 Gabriel Goller
2025-11-18 12:18 ` Thomas Lamprecht
2025-11-18 12:35 ` Gabriel Goller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p2qcb7fj2gqxrycb4auahblbiayvx24e25tnvju2iz3bsrfc62@fowy4uuvw573 \
--to=g.goller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox