From: Christoph Heiss <c.heiss@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH common/qemu-server] improve sysfs write behaviour
Date: Wed, 6 Nov 2024 11:51:30 +0100 [thread overview]
Message-ID: <owsiibkloupwb7tdvsk7fwhexf6tr6ryjluftvybrcdb2d55y4@75rzbeyu4w4e> (raw)
In-Reply-To: <20241105092421.774448-1-d.csapak@proxmox.com>
Reviewed-by: Christoph Heiss <c.heiss@proxmox.com>
Tested-by: Christoph Heiss <c.heiss@proxmox.com>
Tested at least to the degree that this series does not regress
anything. (as I don't have any hardware to passthrough that exhibits
that problem in the first place)
On Tue, Nov 05, 2024 at 10:24:19AM +0100, Dominik Csapak wrote:
> As i feared previously in [0], making it a hard error when encountering
> errors during sysfs writes uncovered some situations where our code was
> too strict to keep some setups working.
>
> One such case is resetting devices, which is seemingly not necessary
> at all times, so this series
>
> * donwgrades that error to warning
> * adds some more logging to `file_write` to be able to better debug
>
> Alternatively, we could rewrite file_write such that we can control the
> error behaviour with a parameter and replace all "old" call sites so
> that we ignore errors. But since the only other call sites currently are
> for binding vfio-pci to the device. (which AFAIK is necessary and not
> optional) and setting mdev models (which is also not optional), we should
> mostly be fine with this approach here.
>
> In [1], some users reported it's breaking, at least one with binding of
> vfio-pci, which I'm currently investigating there to see if it's really
> necessary.
>
> 0: https://lore.proxmox.com/pve-devel/20240723082925.934603-1-d.csapak@proxmox.com/
> 1: https://forum.proxmox.com/threads/156848/
>
> pve-common:
>
> Dominik Csapak (1):
> sysfstools: file_write: log the actual error if there was one
>
> src/PVE/SysFSTools.pm | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> qemu-server:
>
> Dominik Csapak (1):
> pci: don't hard require resetting devices for passthrough
>
> PVE/QemuServer/PCI.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --
> 2.39.5
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-11-06 10:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 9:24 Dominik Csapak
2024-11-05 9:24 ` [pve-devel] [PATCH common 1/1] sysfstools: file_write: log the actual error if there was one Dominik Csapak
2024-11-05 9:24 ` [pve-devel] [PATCH qemu-server 1/1] pci: don't hard require resetting devices for passthrough Dominik Csapak
2024-11-05 10:16 ` Stoiko Ivanov
2024-11-05 10:40 ` Dominik Csapak
2024-11-05 10:12 ` [pve-devel] [PATCH common/qemu-server] improve sysfs write behaviour Stoiko Ivanov
2024-11-06 10:51 ` Christoph Heiss [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=owsiibkloupwb7tdvsk7fwhexf6tr6ryjluftvybrcdb2d55y4@75rzbeyu4w4e \
--to=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox