From: Christoph Heiss <c.heiss@proxmox.com>
To: Aaron Lauterer <a.lauterer@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 2/2] fix#5570 ui: ceph: make MDS ID configurable
Date: Wed, 10 Jul 2024 15:59:36 +0200 [thread overview]
Message-ID: <nikbaanopxz3a7mpjgapxdb6va6lptszkst22oq2xxtoohzarb@3j74q3b5xnw3> (raw)
In-Reply-To: <20240710124300.295817-3-a.lauterer@proxmox.com>
On Wed, Jul 10, 2024 at 02:43:00PM GMT, Aaron Lauterer wrote:
> [..]
> www/manager6/ceph/ServiceList.js | 21 +++++++++++----------
> 1 file changed, 11 insertions(+), 10 deletions(-)
>
> diff --git a/www/manager6/ceph/ServiceList.js b/www/manager6/ceph/ServiceList.js
> index 76710146..9075f197 100644
> --- a/www/manager6/ceph/ServiceList.js
> +++ b/www/manager6/ceph/ServiceList.js
> [..]
> @@ -40,15 +39,17 @@ Ext.define('PVE.CephCreateService', {
> listeners: {
> change: function(f, value) {
> let view = this.up('pveCephCreateService');
> + view.lookup('mds-id').setValue(value);
> view.setNode(value);
> },
> },
> },
> {
> xtype: 'textfield',
> - fieldLabel: gettext('Extra ID'),
> - regex: /[a-zA-Z0-9]+/,
> - regexText: gettext('ID may only consist of alphanumeric characters'),
> + reference: 'mds-id',
> + fieldLabel: gettext('MDS ID'),
> + regex: /^([a-zA-Z]([-a-zA-Z0-9]*[a-zA-Z0-9])?)$/,
> + regexText: gettext('ID may consist of alphanumeric characters and hyphen. It cannot start with a number or end in a hyphen.'),
Is there a check in the backend whether the name ends with a hyphen? If
not, should there be one?
Also, while at it, maybe also set `maxLength` to a sensible value?
E.g. while the API schema allows up to 200 characters, it then fails to
create a task log file with "File name too long" :^)
~ 180 characters seem to be fine, but probably something like 128
characters is already a pretty sensible limit.
> submitValue: false,
> emptyText: Proxmox.Utils.NoneText,
> cbind: {
> @@ -58,7 +59,7 @@ Ext.define('PVE.CephCreateService', {
> listeners: {
> change: function(f, value) {
> let view = this.up('pveCephCreateService');
> - view.setExtraID(value);
> + view.setServiceID(value);
> },
> },
> },
> @@ -73,7 +74,7 @@ Ext.define('PVE.CephCreateService', {
> cbind: {
> hidden: get => get('type') !== 'mds',
> },
> - html: gettext('The Extra ID allows creating multiple MDS per node, which increases redundancy with more than one CephFS.'),
> + html: gettext('By using different IDs, you can have multiple MDS per node, which increases redundancy with more than one CephFS.'),
> },
> ],
>
> --
> 2.39.2
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-07-10 13:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-10 12:42 [pve-devel] [PATCH manager 0/2] fix #5570 ceph mds: allow custom MDS IDs from the UI Aaron Lauterer
2024-07-10 12:42 ` [pve-devel] [PATCH manager 1/2] api: ceph mds: avoid creating MDS when ID starts with number Aaron Lauterer
2024-07-10 12:43 ` [pve-devel] [PATCH manager 2/2] fix#5570 ui: ceph: make MDS ID configurable Aaron Lauterer
2024-07-10 13:59 ` Christoph Heiss [this message]
2024-07-10 14:18 ` Aaron Lauterer
2024-07-10 14:24 ` Christoph Heiss
2024-07-10 13:59 ` [pve-devel] [PATCH manager 0/2] fix #5570 ceph mds: allow custom MDS IDs from the UI Christoph Heiss
2024-07-22 16:57 ` [pve-devel] applied-series: " Thomas Lamprecht
2024-07-23 6:52 ` Aaron Lauterer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nikbaanopxz3a7mpjgapxdb6va6lptszkst22oq2xxtoohzarb@3j74q3b5xnw3 \
--to=c.heiss@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox