From: Gabriel Goller <g.goller@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH widget-toolkit v3 4/4] form: set enforceMaxLength on textareafield
Date: Thu, 27 Feb 2025 13:37:22 +0100 [thread overview]
Message-ID: <n5hxbvhwz26grvc5fjt4qaeaudbfplhjoeodolmnnwru25rit5@7xypvpdntwtd> (raw)
In-Reply-To: <ad7b7f07-d516-41fe-afb8-b71204b2663b@proxmox.com>
On 26.02.2025 18:59, Thomas Lamprecht wrote:
>Am 10.12.24 um 17:11 schrieb Gabriel Goller:
>> This allows us to set `maxLength` on it. `enforceMaxLength` will force
>> extjs to set the `maxLength` property on the underlying inputfield.
>>
>
>isn't it enough to make the field invalid?
>
>It might not be a big problem in practice here, but personally I find
>it slightly infuriating if there is a hard blocker for going over a text
>length limit, as that makes restructuring the text to a shorter variant
>harder to do, as there it's often useful to be able to (temporarily) write
>a longer text as what it's allowed to submit.
Agreed. We can drop the last patch.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-02-27 12:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 16:11 [pve-devel] [PATCH cluster/docs/manager/widget-toolkit v3 0/4] fix #5463: add optional Consent Banner on login Gabriel Goller
2024-12-10 16:11 ` [pve-devel] [PATCH manager v3 1/4] show optional consent-banner before login Gabriel Goller
2024-12-10 16:11 ` [pve-devel] [PATCH cluster v3 2/4] add consent-text parameter to datacenter config file Gabriel Goller
2024-12-10 16:11 ` [pve-devel] [PATCH docs v3 3/4] add consent-banner description Gabriel Goller
2024-12-10 16:11 ` [pve-devel] [PATCH widget-toolkit v3 4/4] form: set enforceMaxLength on textareafield Gabriel Goller
2025-02-26 17:59 ` Thomas Lamprecht
2025-02-27 12:37 ` Gabriel Goller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=n5hxbvhwz26grvc5fjt4qaeaudbfplhjoeodolmnnwru25rit5@7xypvpdntwtd \
--to=g.goller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal