From: Christoph Heiss <c.heiss@proxmox.com>
To: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH installer] auto-installer: fix answer-request charset
Date: Fri, 5 Jul 2024 10:02:31 +0200 [thread overview]
Message-ID: <mu6flgx6vwnfc67daad57ldkaa2lctknmt2sybh2mxjeg4ib2u@7oabmxhfx3z5> (raw)
In-Reply-To: <20240426081255.197999-1-f.gruenbichler@proxmox.com>
Important fix, apparently slipped through in April.
"Re-discovered" it yesterday by coincidence while talking to Aaron.
On Fri, Apr 26, 2024 at 10:12:55AM GMT, Fabian Grünbichler wrote:
> 'utf-' is a typo, and can trip up some servers that do strict
> checking/matching.
>
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
Reviewed-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
>
> Notes:
> see https://forum.proxmox.com/threads/invalid-charset-on-automated-install-answer-http-fetch.145856/
>
> proxmox-fetch-answer/src/fetch_plugins/http.rs | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/proxmox-fetch-answer/src/fetch_plugins/http.rs b/proxmox-fetch-answer/src/fetch_plugins/http.rs
> index 1c5e9ea..21bc6a2 100644
> --- a/proxmox-fetch-answer/src/fetch_plugins/http.rs
> +++ b/proxmox-fetch-answer/src/fetch_plugins/http.rs
> @@ -211,7 +211,7 @@ mod http_post {
>
> answer = agent
> .post(&url)
> - .set("Content-type", "application/json; charset=utf-")
> + .set("Content-type", "application/json; charset=utf-8")
> .send_string(&payload)?
> .into_string()?;
> } else {
> @@ -231,7 +231,7 @@ mod http_post {
> .build();
> answer = agent
> .post(&url)
> - .set("Content-type", "application/json; charset=utf-")
> + .set("Content-type", "application/json; charset=utf-8")
> .timeout(std::time::Duration::from_secs(60))
> .send_string(&payload)?
> .into_string()?;
> --
> 2.39.2
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-07-05 8:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 8:12 Fabian Grünbichler
2024-07-05 8:02 ` Christoph Heiss [this message]
2024-07-05 8:19 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mu6flgx6vwnfc67daad57ldkaa2lctknmt2sybh2mxjeg4ib2u@7oabmxhfx3z5 \
--to=c.heiss@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox