public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Alexandre Derumier via pve-devel <pve-devel@lists.proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Alexandre Derumier <alexandre.derumier@groupe-cyllene.com>
Subject: [pve-devel] [PATCH-SERIES v4 pve-storage/qemu-server/pve-qemu] add external qcow2 snapshot support
Date: Tue, 11 Mar 2025 11:28:48 +0100	[thread overview]
Message-ID: <mailman.958.1741688988.293.pve-devel@lists.proxmox.com> (raw)

[-- Attachment #1: Type: message/rfc822, Size: 6955 bytes --]

From: Alexandre Derumier <alexandre.derumier@groupe-cyllene.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH-SERIES v4 pve-storage/qemu-server/pve-qemu] add external qcow2 snapshot support
Date: Tue, 11 Mar 2025 11:28:48 +0100
Message-ID: <20250311102905.2680524-1-alexandre.derumier@groupe-cyllene.com>

This patch series implement qcow2 external snapshot support for files && lvm volumes

The current internal qcow2 snapshots have bad write performance because no metadatas can be preallocated.

This is particulary visible on a shared filesystem like ocfs2 or gfs2.

Also other bugs are freeze/lock reported by users since years on snapshots delete on nfs
(The disk access seem to be frozen during all the delete duration)

This also open doors for remote snapshot export-import for storage replication.

Changelog v4:
     - use blocknode fixed names with sha1+base62
     - use block-stream for snapshot delete
     - qemu : use throttle qom object (no more x-throttle )
     - various cleanup && refactoring from fabian comments

MAIN TODO:
    - convert/implement all the backup code, dirty dirty bitmap, ...
    - iscsi blockdev syntax
    - ceph keyring as blockdev option
    - unit tests
    


storage.cfg example:

dir: local2
        path /var/liv/vz
        content snippets,vztmpl,backup,images,iso,rootdir
        snapext 1

lvm:test
        vgname test
        content images


pve-storage:

Alexandre Derumier (5):
  qcow2: add external snapshot support
  lvmplugin: add qcow2 snapshot
  storage: vdisk_free: remove external snapshots
  lvm: lvrename helper: allow path
  lvm: add lvremove helper

 src/PVE/Storage.pm                 |  22 ++-
 src/PVE/Storage/DirPlugin.pm       |   1 +
 src/PVE/Storage/LVMPlugin.pm       | 251 ++++++++++++++++++++++++++---
 src/PVE/Storage/Plugin.pm          | 232 +++++++++++++++++++++-----
 src/test/run_test_zfspoolplugin.pl |  18 +++
 5 files changed, 456 insertions(+), 68 deletions(-)

qemu-server:

Alexandre Derumier (11):
  blockdev: cmdline: convert drive to blockdev syntax
  blockdev : convert qemu_driveadd && qemu_drivedel
  replace qemu_block_set_io_throttle with qom-set throttlegroup limits
  blockdev: vm_devices_list : fix block-query
  blockdev: convert cdrom media eject/insert
  blockdev: block_resize: convert to blockdev
  blockdev: nbd_export: block-export-add : use drive-$id for nodename
  blockdev: convert drive_mirror to blockdev_mirror
  blockdev: change aio on target if io_uring is not default.
  blockdev: add backing_chain support
  qcow2: add external snapshot support

 PVE/QemuConfig.pm                             |   4 +-
 PVE/QemuMigrate.pm                            |   2 +-
 PVE/QemuServer.pm                             | 632 +++++++++---------
 PVE/QemuServer/Drive.pm                       | 415 ++++++++++++
 test/MigrationTest/QemuMigrateMock.pm         |  10 +-
 test/cfg2cmd/bootorder-empty.conf.cmd         |  12 +-
 test/cfg2cmd/bootorder-legacy.conf.cmd        |  12 +-
 test/cfg2cmd/bootorder.conf.cmd               |  12 +-
 ...putype-icelake-client-deprecation.conf.cmd |   6 +-
 test/cfg2cmd/ide.conf.cmd                     |  23 +-
 test/cfg2cmd/pinned-version-pxe-pve.conf.cmd  |   6 +-
 test/cfg2cmd/pinned-version-pxe.conf.cmd      |   6 +-
 test/cfg2cmd/pinned-version.conf.cmd          |   6 +-
 test/cfg2cmd/q35-ide.conf.cmd                 |  23 +-
 .../q35-linux-hostpci-template.conf.cmd       |   3 +-
 test/cfg2cmd/seabios_serial.conf.cmd          |   6 +-
 ...imple-balloon-free-page-reporting.conf.cmd |   6 +-
 test/cfg2cmd/simple-btrfs.conf.cmd            |   6 +-
 test/cfg2cmd/simple-virtio-blk.conf.cmd       |   6 +-
 test/cfg2cmd/simple1-template.conf.cmd        |  11 +-
 test/cfg2cmd/simple1-throttle.conf            |  14 +
 test/cfg2cmd/simple1-throttle.conf.cmd        |  33 +
 test/cfg2cmd/simple1.conf.cmd                 |   6 +-
 23 files changed, 886 insertions(+), 374 deletions(-)
 create mode 100644 test/cfg2cmd/simple1-throttle.conf
 create mode 100644 test/cfg2cmd/simple1-throttle.conf.cmd

pve-qemu:

Alexandre Derumier (1):
  add block-commit-replaces option patch

 ...051-block-commit-add-replaces-option.patch | 137 ++++++++++++++++++
 debian/patches/series                         |   1 +
 2 files changed, 138 insertions(+)
 create mode 100644 debian/patches/pve/0051-block-commit-add-replaces-option.patch

-- 
2.39.5



[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

                 reply	other threads:[~2025-03-11 10:31 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mailman.958.1741688988.293.pve-devel@lists.proxmox.com \
    --to=pve-devel@lists.proxmox.com \
    --cc=alexandre.derumier@groupe-cyllene.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal