public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak via pve-devel <pve-devel@lists.proxmox.com>
To: Lukas Wagner <l.wagner@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v7 0/3] allow importing vm disk images on the UI
Date: Thu, 10 Apr 2025 14:06:22 +0200	[thread overview]
Message-ID: <mailman.912.1744286820.359.pve-devel@lists.proxmox.com> (raw)
In-Reply-To: <c7b3dfb5-89aa-4f42-927d-08475d17e7f0@proxmox.com>

[-- Attachment #1: Type: message/rfc822, Size: 3467 bytes --]

From: Dominik Csapak <d.csapak@proxmox.com>
To: Lukas Wagner <l.wagner@proxmox.com>, Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v7 0/3] allow importing vm disk images on the UI
Date: Thu, 10 Apr 2025 14:06:22 +0200
Message-ID: <2ace65d7-641d-422d-83e8-e31f24d10a63@proxmox.com>

On 4/10/25 14:04, Lukas Wagner wrote:
> 
> 
> On  2025-04-08 14:13, Dominik Csapak wrote:
>> this is a continuation of my previous series [0]
>>
>> It enables importing disks on the UI in the HardwareView of a vm,
>> in the create wizard, and in the storage content view.
>>
>> I split the patches so that the wizard and storage content view one are
>> separate, so they can be reviewed independently.
>>
> 
> Gave this a quick test on the latest pve-manager master branch. Seems to work as advertised.
> Tried importing from the Create-VM wizard, by going to the Hardware tab a VM as well
> as from the storage view itself.
> 
> Noticed that under "Download from URL" there is no way to automatically extract compressed
> images the same way as we do it for ISO images. Is there some technical reason for this?
> Or is it just not implemented yet? Anyway, would be a nice addition for a
> future patch series :)

yeah, it's just not implemented yet, but it totally makes sense to have in the future

Thanks for testing!

> 
> Tested-by: Lukas Wagner <l.wagner@proxmox.com>
> 




[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

      parent reply	other threads:[~2025-04-10 12:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-08 12:13 Dominik Csapak
2025-04-08 12:13 ` [pve-devel] [PATCH manager v7 1/3] ui: qemu hd edit: allow importing a disk from the import storage Dominik Csapak
2025-04-08 12:13 ` [pve-devel] [PATCH manager v7 2/3] ui: vm create wizard: allow importing disks Dominik Csapak
2025-04-08 12:13 ` [pve-devel] [PATCH manager v7 3/3] ui: import storage content: allow importing of vm disk images Dominik Csapak
2025-04-08 15:34   ` Thomas Lamprecht
2025-04-09  7:10     ` Dominik Csapak
2025-04-10 11:39       ` Gilberto Ferreira via pve-devel
2025-04-10 12:04         ` Dominik Csapak via pve-devel
2025-04-10 12:13           ` Gilberto Ferreira via pve-devel
2025-04-10 12:25           ` Gilberto Ferreira via pve-devel
2025-04-08 15:44 ` [pve-devel] [PATCH manager v7 0/3] allow importing vm disk images on the UI Michael Köppl
2025-04-10 12:04 ` Lukas Wagner via pve-devel
     [not found] ` <c7b3dfb5-89aa-4f42-927d-08475d17e7f0@proxmox.com>
2025-04-10 12:06   ` Dominik Csapak via pve-devel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mailman.912.1744286820.359.pve-devel@lists.proxmox.com \
    --to=pve-devel@lists.proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=l.wagner@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal