[pve-devel] SPAM: [PATCH pve-network 0/2] fix #5949

[pve-devel] SPAM: [PATCH pve-network 0/2] fix #5949

[Lou Lecrivain via pve-devel]

[-- Attachment #1: Type: message/rfc822, Size: 4743 bytes --]

From: Lou Lecrivain <lou.lecrivain@wdz.de>
To: pve-devel@lists.proxmox.com
Subject: SPAM: [PATCH pve-network 0/2] fix #5949
Date: Thu, 28 Nov 2024 18:09:40 +0100
Message-ID: <20241128170942.4717-1-lou.lecrivain@wdz.de>

this patch series re-enables a previously disabled code path in order to
allow IP allocation directly from a prefix when no DHCP ranges
are configured for a subnet.

2nd commit is a workaround for dnsmasq crash when a dhcp lease is
updated via dbus and no dhcp-range is configured.

The whole patch series requires #5946 patch to work.

MfG
--
Lou Lecrivain
WDZ GmbH

Lou Lecrivain (2):
  vnet: do not skip if no range is defined, ask for allocation inside
    prefix instead
  dhcp: generate dhcp-range for dnsmasq even when no dhcp_ranges exist

 src/PVE/Network/SDN/Dhcp.pm         | 6 ++++--
 src/PVE/Network/SDN/Dhcp/Dnsmasq.pm | 5 ++++-
 src/PVE/Network/SDN/Dhcp/Plugin.pm  | 2 +-
 src/PVE/Network/SDN/Vnets.pm        | 4 ++--
 4 files changed, 11 insertions(+), 6 deletions(-)

-- 
2.39.5



[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] SPAM: [PATCH pve-network 0/2] fix #5949

[Stefan Hanreich]

> The whole patch series requires #5946 patch to work.

Do you mean #5496? Is there any specific reason why this requires the
NetboxPlugin fix? Should be unrelated, as far as I can tell?


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] SPAM: [PATCH pve-network 0/2] fix #5949

[Lou Lecrivain via pve-devel]

[-- Attachment #1: Type: message/rfc822, Size: 11773 bytes --]

From: <Lou.Lecrivain@wdz.de>
To: <s.hanreich@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] SPAM: [PATCH pve-network 0/2] fix #5949
Date: Thu, 5 Dec 2024 15:56:35 +0000
Message-ID: <BE1P281MB21160E7996A7D433D79BC45185302@BE1P281MB2116.DEUP281.PROD.OUTLOOK.COM>

Re,

Yes, was a typo on my end. Meant to type #5496.

It isn't a hard requirement, more like "there will be no API calls made if the other fix isn't present".
But, in itself, the patch will not fix the whole issue, since if no API calls are made we'll still have errors, even if we now go through the correct code path.

BR
________________________________________
De : Stefan Hanreich <s.hanreich@proxmox.com>
Envoyé : jeudi 5 décembre 2024 16:49
À : Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc : Lecrivain, Lou (WDZ) <Lou.Lecrivain@wdz.de>
Objet : [!!ACHTUNG extern!!] - Re: [pve-devel] SPAM: [PATCH pve-network 0/2] fix #5949
 
> The whole patch series requires #5946 patch to work.

Do you mean #5496? Is there any specific reason why this requires the
NetboxPlugin fix? Should be unrelated, as far as I can tell?


[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] SPAM: [PATCH pve-network 0/2] fix #5949

[Stefan Hanreich]

This patch series would change the behavior of zones with DHCP enabled
as follows:

Currently you need to explicitly configure a DHCP range, otherwise DHCP
doesn't work. With this patch series, an IP *always* gets allocated in
the IPAM when DHCP is enabled and served via DHCP.

This is an okay change in behavior I'd say, since it makes it easier to
just use DHCP if you want to manage the whole prefix via DHCP. We should
probably document it though.
It would also change the behavior for current setups that have DHCP
enabled, but no DHCP-Range configured. Might be a fringe case, but maybe
still worth to consider since those users would suddenly have a DHCP
server running on their PVE node when they re-apply the SDN configuration.


Another thing I noticed while testing:

Since we now use add_next_freeip() as well, this function does not save
the VMID in the PVE IPAM, leading to entries with no VMID and hostname
(see PVEPlugin). Would be nice if we added that as well to the
add_next_freeip() function - it already is there in add_range_next_freeip()


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel