* Re: [pve-devel] TrueNAS over iSCSI: Snapshot Management [not found] <DM6PR17MB34662F5ABDA587979C0FFDA2D019A@DM6PR17MB3466.namprd17.prod.outlook.com> @ 2025-10-05 4:11 ` Lorne Guse via pve-devel [not found] ` <DM6PR17MB346659F576D1D081C71CCC6DD0E2A@DM6PR17MB3466.namprd17.prod.outlook.com> 1 sibling, 0 replies; 8+ messages in thread From: Lorne Guse via pve-devel @ 2025-10-05 4:11 UTC (permalink / raw) To: Proxmox VE development discussion, m.carrara, Morgan Littlewood Cc: Lorne Guse [-- Attachment #1: Type: message/rfc822, Size: 11677 bytes --] From: Lorne Guse <boomshankerx@hotmail.com> To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, "m.carrara@proxmox.com" <m.carrara@proxmox.com>, Morgan Littlewood <morgan@truenas.com> Subject: Re: TrueNAS over iSCSI: Snapshot Management Date: Sun, 5 Oct 2025 04:11:49 +0000 Message-ID: <DM6PR17MB346659F576D1D081C71CCC6DD0E2A@DM6PR17MB3466.namprd17.prod.outlook.com> I was wondering if anyone got a chance to see this message. I'd like to know if there is a mechanism for importing TrueNAS snapshots into Proxmox. This would allow things like periodic snapshots on the TrueNAS side to integrate into Proxmox. -- Lorne Guse ________________________________ From: Lorne Guse <boomshankerx@hotmail.com> Sent: Saturday, September 27, 2025 10:45 AM To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>; m.carrara@proxmox.com <m.carrara@proxmox.com>; Morgan Littlewood <morgan@truenas.com> Subject: TrueNAS over iSCSI: Snapshot Management I'd like to get some input on snapshot management relating to TrueNAS. Currently, Proxmox does not allow for multigeneration rollback of snapshots. TASK ERROR: can't rollback, 'preupgrade' is not most recent snapshot on 'nas:vm-803-disk-0' I was wondering if there is a way for Proxmox to allow for the use of TrueNAS periodic snapshots without breaking Proxmox snapshots. Is there a way to import TrueNAS snapshots into Proxmox via the API? Could multi-generation rollback work because TrueNAS supports it? -- Lorne Guse [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <DM6PR17MB346659F576D1D081C71CCC6DD0E2A@DM6PR17MB3466.namprd17.prod.outlook.com>]
* Re: [pve-devel] TrueNAS over iSCSI: Snapshot Management [not found] ` <DM6PR17MB346659F576D1D081C71CCC6DD0E2A@DM6PR17MB3466.namprd17.prod.outlook.com> @ 2025-10-05 22:02 ` Morgan Littlewood via pve-devel [not found] ` <CABr3vq+8FF-T0NC=aTXq6ke_PgSYjJhbo0Pk4BPT64vRHbMC+w@mail.gmail.com> 1 sibling, 0 replies; 8+ messages in thread From: Morgan Littlewood via pve-devel @ 2025-10-05 22:02 UTC (permalink / raw) To: Lorne Guse; +Cc: Morgan Littlewood, Proxmox VE development discussion [-- Attachment #1: Type: message/rfc822, Size: 6980 bytes --] From: Morgan Littlewood <morgan@truenas.com> To: Lorne Guse <boomshankerx@hotmail.com> Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, "m.carrara@proxmox.com" <m.carrara@proxmox.com> Subject: Re: TrueNAS over iSCSI: Snapshot Management Date: Sun, 5 Oct 2025 15:02:37 -0700 Message-ID: <CABr3vq+8FF-T0NC=aTXq6ke_PgSYjJhbo0Pk4BPT64vRHbMC+w@mail.gmail.com> I'd recommend that Proxmox do the snapshots (periodic or not) so thta it is aware of all snapshots and their retention time. It is the master and decides when snapshots should be deleted. Proxmox also has a schance to quisece the VMs and so the snapshots will be application and not just crash-consistent. This is a cleaner experience for the VMs and users. TrueNAS will just take, list and delete the snapshots efficiently based on plugin and API request. On Sat, Oct 4, 2025 at 9:11 PM Lorne Guse <boomshankerx@hotmail.com> wrote: > I was wondering if anyone got a chance to see this message. I'd like to > know if there is a mechanism for importing TrueNAS snapshots into Proxmox. > > This would allow things like periodic snapshots on the TrueNAS side to > integrate into Proxmox. > > -- > Lorne Guse > ------------------------------ > *From:* Lorne Guse <boomshankerx@hotmail.com> > *Sent:* Saturday, September 27, 2025 10:45 AM > *To:* Proxmox VE development discussion <pve-devel@lists.proxmox.com>; > m.carrara@proxmox.com <m.carrara@proxmox.com>; Morgan Littlewood < > morgan@truenas.com> > *Subject:* TrueNAS over iSCSI: Snapshot Management > > I'd like to get some input on snapshot management relating to TrueNAS. > Currently, Proxmox does not allow for multigeneration rollback of snapshots. > > TASK ERROR: can't rollback, 'preupgrade' is not most recent snapshot on > 'nas:vm-803-disk-0' > > I was wondering if there is a way for Proxmox to allow for the use of > TrueNAS periodic snapshots without breaking Proxmox snapshots. > > Is there a way to import TrueNAS snapshots into Proxmox via the API? > > Could multi-generation rollback work because TrueNAS supports it? > > > -- > Lorne Guse > [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <CABr3vq+8FF-T0NC=aTXq6ke_PgSYjJhbo0Pk4BPT64vRHbMC+w@mail.gmail.com>]
* Re: [pve-devel] TrueNAS over iSCSI: Snapshot Management [not found] ` <CABr3vq+8FF-T0NC=aTXq6ke_PgSYjJhbo0Pk4BPT64vRHbMC+w@mail.gmail.com> @ 2025-10-06 1:09 ` Lorne Guse via pve-devel [not found] ` <DM6PR17MB3466C924D9FC9565703D5B64D0E3A@DM6PR17MB3466.namprd17.prod.outlook.com> 1 sibling, 0 replies; 8+ messages in thread From: Lorne Guse via pve-devel @ 2025-10-06 1:09 UTC (permalink / raw) To: Morgan Littlewood; +Cc: Lorne Guse, Proxmox VE development discussion [-- Attachment #1: Type: message/rfc822, Size: 13950 bytes --] From: Lorne Guse <boomshankerx@hotmail.com> To: Morgan Littlewood <morgan@truenas.com> Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, "m.carrara@proxmox.com" <m.carrara@proxmox.com> Subject: Re: TrueNAS over iSCSI: Snapshot Management Date: Mon, 6 Oct 2025 01:09:53 +0000 Message-ID: <DM6PR17MB3466C924D9FC9565703D5B64D0E3A@DM6PR17MB3466.namprd17.prod.outlook.com> Ok, I won't overcomplicate it then. ________________________________ From: Morgan Littlewood <morgan@truenas.com> Sent: Sunday, October 5, 2025 4:02 PM To: Lorne Guse <boomshankerx@hotmail.com> Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>; m.carrara@proxmox.com <m.carrara@proxmox.com> Subject: Re: TrueNAS over iSCSI: Snapshot Management I'd recommend that Proxmox do the snapshots (periodic or not) so thta it is aware of all snapshots and their retention time. It is the master and decides when snapshots should be deleted. Proxmox also has a schance to quisece the VMs and so the snapshots will be application and not just crash-consistent. This is a cleaner experience for the VMs and users. TrueNAS will just take, list and delete the snapshots efficiently based on plugin and API request. On Sat, Oct 4, 2025 at 9:11 PM Lorne Guse <boomshankerx@hotmail.com<mailto:boomshankerx@hotmail.com>> wrote: I was wondering if anyone got a chance to see this message. I'd like to know if there is a mechanism for importing TrueNAS snapshots into Proxmox. This would allow things like periodic snapshots on the TrueNAS side to integrate into Proxmox. -- Lorne Guse ________________________________ From: Lorne Guse <boomshankerx@hotmail.com<mailto:boomshankerx@hotmail.com>> Sent: Saturday, September 27, 2025 10:45 AM To: Proxmox VE development discussion <pve-devel@lists.proxmox.com<mailto:pve-devel@lists.proxmox.com>>; m.carrara@proxmox.com<mailto:m.carrara@proxmox.com> <m.carrara@proxmox.com<mailto:m.carrara@proxmox.com>>; Morgan Littlewood <morgan@truenas.com<mailto:morgan@truenas.com>> Subject: TrueNAS over iSCSI: Snapshot Management I'd like to get some input on snapshot management relating to TrueNAS. Currently, Proxmox does not allow for multigeneration rollback of snapshots. TASK ERROR: can't rollback, 'preupgrade' is not most recent snapshot on 'nas:vm-803-disk-0' I was wondering if there is a way for Proxmox to allow for the use of TrueNAS periodic snapshots without breaking Proxmox snapshots. Is there a way to import TrueNAS snapshots into Proxmox via the API? Could multi-generation rollback work because TrueNAS supports it? -- Lorne Guse [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <DM6PR17MB3466C924D9FC9565703D5B64D0E3A@DM6PR17MB3466.namprd17.prod.outlook.com>]
* Re: [pve-devel] TrueNAS over iSCSI: Snapshot Management [not found] ` <DM6PR17MB3466C924D9FC9565703D5B64D0E3A@DM6PR17MB3466.namprd17.prod.outlook.com> @ 2025-10-06 13:17 ` Max R. Carrara 2025-10-06 19:59 ` Morgan Littlewood via pve-devel [not found] ` <CABr3vqKwJgwFu+A=Jjw_hSEwwjz=3X+ZU7kkBrmyuppWSaKxhQ@mail.gmail.com> 0 siblings, 2 replies; 8+ messages in thread From: Max R. Carrara @ 2025-10-06 13:17 UTC (permalink / raw) To: Lorne Guse, Morgan Littlewood; +Cc: Proxmox VE development discussion On Mon Oct 6, 2025 at 3:09 AM CEST, Lorne Guse wrote: > [...] Hi Lorne, hi Morgan! Sorry—only now finally got some time to look into this. Regarding multi-generational snapshot rollbacks: That is something that's possible actually; our `lvm-thin` storage supports that, for example [0]. You're probably running into the default implementation [1], hence the error. We don't support it for our ZFS pool storage though [2] (and thus also not for the ZFS over iSCSI storages), since `zfs rollback` doesn't support it without destroying intermediate snapshots [3]. The user can still do rollbacks on older snapshots, they just have to delete the intermediate ones first, in this case. (So basically what `zfs rollback` requires one to do.) With all that being said, I agree with Morgan here; it's best to just let PVE manage the snapshots and whatever contents are on the volume, as it is a cleaner experience for the user. (Principle of least surprise and all that.) Hope that helps! If you need anything else, feel free to ping me! (: [0]: https://git.proxmox.com/?p=pve-storage.git;a=blob;f=src/PVE/Storage/LvmThinPlugin.pm;h=ccefd0eb24630a4ae5e206002760126dfce9304a;hb=refs/heads/master#l366 [1]: https://git.proxmox.com/?p=pve-storage.git;a=blob;f=src/PVE/Storage/Plugin.pm;h=2291d72d929b9de83f7703aae146372e4b663860;hb=refs/heads/master#l1325 [2]: https://git.proxmox.com/?p=pve-storage.git;a=blob;f=src/PVE/Storage/ZFSPoolPlugin.pm;h=3b3456b7482ad4388a757e80484412384a677da1;hb=refs/heads/master#l551 [3]: https://openzfs.github.io/openzfs-docs/man/master/8/zfs-rollback.8.html _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [pve-devel] TrueNAS over iSCSI: Snapshot Management 2025-10-06 13:17 ` Max R. Carrara @ 2025-10-06 19:59 ` Morgan Littlewood via pve-devel [not found] ` <CABr3vqKwJgwFu+A=Jjw_hSEwwjz=3X+ZU7kkBrmyuppWSaKxhQ@mail.gmail.com> 1 sibling, 0 replies; 8+ messages in thread From: Morgan Littlewood via pve-devel @ 2025-10-06 19:59 UTC (permalink / raw) To: Max R. Carrara; +Cc: Morgan Littlewood, Proxmox VE development discussion [-- Attachment #1: Type: message/rfc822, Size: 7718 bytes --] From: Morgan Littlewood <morgan@truenas.com> To: "Max R. Carrara" <m.carrara@proxmox.com> Cc: Lorne Guse <boomshankerx@hotmail.com>, Proxmox VE development discussion <pve-devel@lists.proxmox.com> Subject: Re: TrueNAS over iSCSI: Snapshot Management Date: Mon, 6 Oct 2025 12:59:24 -0700 Message-ID: <CABr3vqKwJgwFu+A=Jjw_hSEwwjz=3X+ZU7kkBrmyuppWSaKxhQ@mail.gmail.com> Rollback to last snapshot is acceptable for 99.9% of situations.... For deleting intermediate snapshots.. can this be done on TrueNAS UI or does proxmox control this? If done on TrueNAS, can Proxmox learn about (adjust to) deleted snapshots? On Mon, Oct 6, 2025 at 6:17 AM Max R. Carrara <m.carrara@proxmox.com> wrote: > On Mon Oct 6, 2025 at 3:09 AM CEST, Lorne Guse wrote: > > [...] > > Hi Lorne, hi Morgan! > > Sorry—only now finally got some time to look into this. > > Regarding multi-generational snapshot rollbacks: That is something > that's possible actually; our `lvm-thin` storage supports that, for > example [0]. You're probably running into the default implementation [1], > hence the error. > > We don't support it for our ZFS pool storage though [2] (and thus also > not for the ZFS over iSCSI storages), since `zfs rollback` doesn't > support it without destroying intermediate snapshots [3]. > > The user can still do rollbacks on older snapshots, they just have to > delete the intermediate ones first, in this case. (So basically what > `zfs rollback` requires one to do.) > > With all that being said, I agree with Morgan here; it's best to just > let PVE manage the snapshots and whatever contents are on the volume, as > it is a cleaner experience for the user. (Principle of least surprise > and all that.) > > Hope that helps! If you need anything else, feel free to ping me! (: > > [0]: > https://git.proxmox.com/?p=pve-storage.git;a=blob;f=src/PVE/Storage/LvmThinPlugin.pm;h=ccefd0eb24630a4ae5e206002760126dfce9304a;hb=refs/heads/master#l366 > [1]: > https://git.proxmox.com/?p=pve-storage.git;a=blob;f=src/PVE/Storage/Plugin.pm;h=2291d72d929b9de83f7703aae146372e4b663860;hb=refs/heads/master#l1325 > [2]: > https://git.proxmox.com/?p=pve-storage.git;a=blob;f=src/PVE/Storage/ZFSPoolPlugin.pm;h=3b3456b7482ad4388a757e80484412384a677da1;hb=refs/heads/master#l551 > [3]: > https://openzfs.github.io/openzfs-docs/man/master/8/zfs-rollback.8.html > > [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <CABr3vqKwJgwFu+A=Jjw_hSEwwjz=3X+ZU7kkBrmyuppWSaKxhQ@mail.gmail.com>]
[parent not found: <DM6PR17MB34668D5F05D76FA32D991250D0E0A@DM6PR17MB3466.namprd17.prod.outlook.com>]
* Re: [pve-devel] TrueNAS over iSCSI: Snapshot Management [not found] ` <DM6PR17MB34668D5F05D76FA32D991250D0E0A@DM6PR17MB3466.namprd17.prod.outlook.com> @ 2025-10-09 15:53 ` Max R. Carrara 2025-10-09 20:05 ` Lorne Guse via pve-devel 0 siblings, 1 reply; 8+ messages in thread From: Max R. Carrara @ 2025-10-09 15:53 UTC (permalink / raw) To: Lorne Guse, Morgan Littlewood; +Cc: Proxmox VE development discussion On Tue Oct 7, 2025 at 3:55 AM CEST, Lorne Guse wrote: > >> For deleting intermediate snapshots.. can this be done on TrueNAS UI or does proxmox control this? >> If done on TrueNAS, can Proxmox learn about (adjust to) deleted snapshots? > It currently doesn't. I ran a test and deleted a snapshot from TrueNAS. The snapshot still exists in Proxmox, but the disk is gone. > > TrueNAS [INFO] : Connected > TrueNAS [INFO] : Authenticated > TrueNAS [INFO] : Version: TrueNAS-25.10-RC.1 > TASK ERROR: can't rollback, snapshot 'test2' does not exist on 'truenas:vm-100-disk-0' > > This is why I was asking if there was a way to "sync" snapshots between platforms. > > Proxmox has an API > https://pve.proxmox.com/pve-docs/api-viewer/index.html#/nodes/{node}/qemu/{vmid}/snapshot<https://pve.proxmox.com/pve-docs/api-viewer/index.html#/nodes/%7Bnode%7D/qemu/%7Bvmid%7D/snapshot> > [...] > > $ pvesh delete /nodes/proxmox9/qemu/100/snapshot/test3 > TrueNAS [INFO] : Connected > TrueNAS [INFO] : Authenticated > TrueNAS [INFO] : Version: TrueNAS-25.10-RC.1 > TrueNAS [INFO] : Deleted snapshot: tank/proxmox/vm-100-disk-0@test3 > > Theoretically, I could pull a list of snapshots from both systems and compare them. This could allow for my original use case of pulling in TrueNAS snapshots as well as also watching for snapshots that have been removed. I can see a path. We should agree on how it should work before I try anything. > Hmm, I mean, in such scenarios I would personally rather say that PVE has the authority over snapshots in that regard, since we're expecting the host / the cluster to have control over the storage; as in, that there are no external influences. (At least, I can't think of any scenario / case off the top of my head where we're taking such external influences into account.) I've sifted through our code a little to see if there's a feasible way of actually doing this without calling the API, relying on any internals or implementation details, but there isn't really. (And `PVE::Storage` amongst other modules isn't expected to call the API at all.) So, what I would suggest instead is shipping some kind of daemon systemd service alongside your plugin—which you totally can do since you're packaging it neatly and all that. That daemon could periodically call our REST API to list snapshots on PVE and also communicate with TrueNAS via its own API (or whatever way you prefer obviously) in order to compare snapshots and prune the missing ones in PVE. Note that you when delete snapshots like that via the REST API, you might have to set `$force` so that it removes the snapshot's config / metadata, even if removing the snapshot itself fails (as it does in this case here). (Side note: If you need to parse & read `/etc/pve/storage.cfg` via that daemon, you can do so via `PVE::Storage::config()` [0] for example.) I think that this route is probably the most feasible / sane / maintainable on your end, because you really don't want to rely on any of our internals, as those aren't versioned like the storage (plugin) API. It's up to you if you want to follow that route of course; personally I would suggest that PVE keeps the authority and that any deviation from that on the storage's side should be considered a user error, but at the same time, I totally see your point. [0]: https://git.proxmox.com/?p=pve-storage.git;a=blob;f=src/PVE/Storage.pm;h=1dde2b751a766a28af8d40df7149936691cca772;hb=refs/heads/master#l232 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [pve-devel] TrueNAS over iSCSI: Snapshot Management 2025-10-09 15:53 ` Max R. Carrara @ 2025-10-09 20:05 ` Lorne Guse via pve-devel 0 siblings, 0 replies; 8+ messages in thread From: Lorne Guse via pve-devel @ 2025-10-09 20:05 UTC (permalink / raw) To: Max R. Carrara, Morgan Littlewood Cc: Lorne Guse, Proxmox VE development discussion [-- Attachment #1: Type: message/rfc822, Size: 17331 bytes --] From: Lorne Guse <boomshankerx@hotmail.com> To: "Max R. Carrara" <m.carrara@proxmox.com>, Morgan Littlewood <morgan@truenas.com> Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Subject: Re: TrueNAS over iSCSI: Snapshot Management Date: Thu, 9 Oct 2025 20:05:54 +0000 Message-ID: <DM6PR17MB3466251A22A4EAB01B2665A9D0EEA@DM6PR17MB3466.namprd17.prod.outlook.com> Thank you for your input. I'm not likely to attempt to implement anything unless the community requests it. I'd much rather see the TPM issue handled. I've had several questions of getting TPM working on shared storage. -- Lorne ________________________________ From: Max R. Carrara <m.carrara@proxmox.com> Sent: Thursday, October 9, 2025 9:53 AM To: Lorne Guse <boomshankerx@hotmail.com>; Morgan Littlewood <morgan@truenas.com> Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Subject: Re: TrueNAS over iSCSI: Snapshot Management On Tue Oct 7, 2025 at 3:55 AM CEST, Lorne Guse wrote: > >> For deleting intermediate snapshots.. can this be done on TrueNAS UI or does proxmox control this? >> If done on TrueNAS, can Proxmox learn about (adjust to) deleted snapshots? > It currently doesn't. I ran a test and deleted a snapshot from TrueNAS. The snapshot still exists in Proxmox, but the disk is gone. > > TrueNAS [INFO] : Connected > TrueNAS [INFO] : Authenticated > TrueNAS [INFO] : Version: TrueNAS-25.10-RC.1 > TASK ERROR: can't rollback, snapshot 'test2' does not exist on 'truenas:vm-100-disk-0' > > This is why I was asking if there was a way to "sync" snapshots between platforms. > > Proxmox has an API > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpve.proxmox.com%2Fpve-docs%2Fapi-viewer%2Findex.html%23%2Fnodes%2F&data=05%7C02%7C%7Cea13097af43d4d6cf8b308de074c029c%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638956220204459798%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=OxivpFSOTTYNf%2FWFOiFbVsn2tU3bDa1hK12RqAiyfQ0%3D&reserved=0{node}/qemu/{vmid}/snapshot<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpve.proxmox.com%2Fpve-docs%2Fapi-viewer%2Findex.html%23%2Fnodes%2F%257Bnode%257D%2Fqemu%2F%257Bvmid%257D%2Fsnapshot&data=05%7C02%7C%7Cea13097af43d4d6cf8b308de074c029c%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638956220204798786%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=Y0Nfuw3%2BawjIyZGuZpMwSgOcA4bfS43kigVg5w7Dxjc%3D&reserved=0><https://pve.proxmox.com/pve-docs/api-viewer/index.html#/nodes/> > [...] > > $ pvesh delete /nodes/proxmox9/qemu/100/snapshot/test3 > TrueNAS [INFO] : Connected > TrueNAS [INFO] : Authenticated > TrueNAS [INFO] : Version: TrueNAS-25.10-RC.1 > TrueNAS [INFO] : Deleted snapshot: tank/proxmox/vm-100-disk-0@test3 > > Theoretically, I could pull a list of snapshots from both systems and compare them. This could allow for my original use case of pulling in TrueNAS snapshots as well as also watching for snapshots that have been removed. I can see a path. We should agree on how it should work before I try anything. > Hmm, I mean, in such scenarios I would personally rather say that PVE has the authority over snapshots in that regard, since we're expecting the host / the cluster to have control over the storage; as in, that there are no external influences. (At least, I can't think of any scenario / case off the top of my head where we're taking such external influences into account.) I've sifted through our code a little to see if there's a feasible way of actually doing this without calling the API, relying on any internals or implementation details, but there isn't really. (And `PVE::Storage` amongst other modules isn't expected to call the API at all.) So, what I would suggest instead is shipping some kind of daemon systemd service alongside your plugin—which you totally can do since you're packaging it neatly and all that. That daemon could periodically call our REST API to list snapshots on PVE and also communicate with TrueNAS via its own API (or whatever way you prefer obviously) in order to compare snapshots and prune the missing ones in PVE. Note that you when delete snapshots like that via the REST API, you might have to set `$force` so that it removes the snapshot's config / metadata, even if removing the snapshot itself fails (as it does in this case here). (Side note: If you need to parse & read `/etc/pve/storage.cfg` via that daemon, you can do so via `PVE::Storage::config()` [0] for example.) I think that this route is probably the most feasible / sane / maintainable on your end, because you really don't want to rely on any of our internals, as those aren't versioned like the storage (plugin) API. It's up to you if you want to follow that route of course; personally I would suggest that PVE keeps the authority and that any deviation from that on the storage's side should be considered a user error, but at the same time, I totally see your point. [0]: https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.proxmox.com%2F%3Fp%3Dpve-storage.git%3Ba%3Dblob%3Bf%3Dsrc%2FPVE%2FStorage.pm%3Bh%3D1dde2b751a766a28af8d40df7149936691cca772%3Bhb%3Drefs%2Fheads%2Fmaster%23l232&data=05%7C02%7C%7Cea13097af43d4d6cf8b308de074c029c%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638956220204819219%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=5U8t7cJ7%2BIX5duV9YhglSLeC6itQQAvSxWiCGfoWYA8%3D&reserved=0<https://git.proxmox.com/?p=pve-storage.git;a=blob;f=src/PVE/Storage.pm;h=1dde2b751a766a28af8d40df7149936691cca772;hb=refs/heads/master#l232> [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* [pve-devel] TrueNAS over iSCSI: Snapshot Management @ 2025-09-27 16:45 Lorne Guse via pve-devel 0 siblings, 0 replies; 8+ messages in thread From: Lorne Guse via pve-devel @ 2025-09-27 16:45 UTC (permalink / raw) To: Proxmox VE development discussion, m.carrara, Morgan Littlewood Cc: Lorne Guse [-- Attachment #1: Type: message/rfc822, Size: 10997 bytes --] From: Lorne Guse <boomshankerx@hotmail.com> To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, "m.carrara@proxmox.com" <m.carrara@proxmox.com>, Morgan Littlewood <morgan@truenas.com> Subject: TrueNAS over iSCSI: Snapshot Management Date: Sat, 27 Sep 2025 16:45:12 +0000 Message-ID: <DM6PR17MB34662F5ABDA587979C0FFDA2D019A@DM6PR17MB3466.namprd17.prod.outlook.com> I'd like to get some input on snapshot management relating to TrueNAS. Currently, Proxmox does not allow for multigeneration rollback of snapshots. TASK ERROR: can't rollback, 'preupgrade' is not most recent snapshot on 'nas:vm-803-disk-0' I was wondering if there is a way for Proxmox to allow for the use of TrueNAS periodic snapshots without breaking Proxmox snapshots. Is there a way to import TrueNAS snapshots into Proxmox via the API? Could multi-generation rollback work because TrueNAS supports it? -- Lorne Guse [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2025-10-09 20:06 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <DM6PR17MB34662F5ABDA587979C0FFDA2D019A@DM6PR17MB3466.namprd17.prod.outlook.com> 2025-10-05 4:11 ` [pve-devel] TrueNAS over iSCSI: Snapshot Management Lorne Guse via pve-devel [not found] ` <DM6PR17MB346659F576D1D081C71CCC6DD0E2A@DM6PR17MB3466.namprd17.prod.outlook.com> 2025-10-05 22:02 ` Morgan Littlewood via pve-devel [not found] ` <CABr3vq+8FF-T0NC=aTXq6ke_PgSYjJhbo0Pk4BPT64vRHbMC+w@mail.gmail.com> 2025-10-06 1:09 ` Lorne Guse via pve-devel [not found] ` <DM6PR17MB3466C924D9FC9565703D5B64D0E3A@DM6PR17MB3466.namprd17.prod.outlook.com> 2025-10-06 13:17 ` Max R. Carrara 2025-10-06 19:59 ` Morgan Littlewood via pve-devel [not found] ` <CABr3vqKwJgwFu+A=Jjw_hSEwwjz=3X+ZU7kkBrmyuppWSaKxhQ@mail.gmail.com> [not found] ` <DM6PR17MB34668D5F05D76FA32D991250D0E0A@DM6PR17MB3466.namprd17.prod.outlook.com> 2025-10-09 15:53 ` Max R. Carrara 2025-10-09 20:05 ` Lorne Guse via pve-devel 2025-09-27 16:45 Lorne Guse via pve-devel
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox