public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Orwa Diraneyya via pve-devel <pve-devel@lists.proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Orwa Diraneyya <info@orwa.tech>,
	Orwa Diraneyya <diraneyyaorwa@gmail.com>
Subject: [pve-devel] [PATCH container] Fix bug #6040 in the exclusion pattern of tar
Date: Sat,  4 Jan 2025 19:47:26 +0100	[thread overview]
Message-ID: <mailman.80.1736016466.441.pve-devel@lists.proxmox.com> (raw)

[-- Attachment #1: Type: message/rfc822, Size: 4470 bytes --]

From: Orwa Diraneyya <info@orwa.tech>
To: pve-devel@lists.proxmox.com
Cc: Orwa Diraneyya <diraneyyaorwa@gmail.com>
Subject: [PATCH container] Fix bug #6040 in the exclusion pattern of tar
Date: Sat,  4 Jan 2025 19:47:26 +0100
Message-ID: <20250104184726.95658-1-info@orwa.tech>

From: Orwa Diraneyya <diraneyyaorwa@gmail.com>

After this fix, users of Proxmox will be able to
use the root filesystem tarballs found publicly
(e.g. at https://cloud-images.ubuntu.com/) as LXC
container templates.

Currently, this results in a container-creation
failure due to the root folder `/dev` exclusion
pattern being ineffective.

The bugfix is also announced on the dev mailing
list (mailman.74.1735960093.441.pve-devel)

Signed-off-by: Orwa Diraneyya <diraneyyaorwa@gmail.com>
---
 src/PVE/LXC/Create.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/LXC/Create.pm b/src/PVE/LXC/Create.pm
index 8c8cb9a..4d0d11e 100644
--- a/src/PVE/LXC/Create.pm
+++ b/src/PVE/LXC/Create.pm
@@ -75,7 +75,7 @@ my sub restore_tar_archive_command {
     # *sigh*, gnu...
     push @$cmd, '--skip-old-files';
     push @$cmd, '--anchored';
-    push @$cmd, '--exclude' , './dev/*';
+    push @$cmd, '--exclude' , 'dev/*';
 
     if (defined($bwlimit)) {
 	$cmd = [ ['cstream', '-t', $bwlimit*1024], $cmd ];
-- 
2.46.0



[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

                 reply	other threads:[~2025-01-04 18:47 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mailman.80.1736016466.441.pve-devel@lists.proxmox.com \
    --to=pve-devel@lists.proxmox.com \
    --cc=diraneyyaorwa@gmail.com \
    --cc=info@orwa.tech \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal