Re: [pve-devel] [PATCH qemu-server 0/2] set write threshold logic

[Joao Sousa via pve-devel <pve-devel@lists.proxmox.com>]

[-- Attachment #1: Type: message/rfc822, Size: 4986 bytes --]

From: Joao Sousa <joao.sousa@eurotux.com>
To: Fiona Ebner <f.ebner@proxmox.com>, Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server 0/2] set write threshold logic
Date: Mon, 11 Aug 2025 21:34:34 +0100
Message-ID: <65e2f286-320a-435c-9846-24aad68f9db7@eurotux.com>

On 8/4/25 10:14 AM, Fiona Ebner wrote:
> blockdev_add()/Blockdev::attach() are only called for hot-plugged disks,
> not disks already present at start-up time. You either need to set the
> threshold as part of the blockdev options in the generate_*_blockdev()
> functions (if that is possible, would be preferred) or issue the QMP
> commands for the initially present disks right after VM start (in
> vm_start_nolock(), we already do something similar for ballooning).

AFAIK the write threshold cannot be set when the blockdev is created, at 
least for now. As you suggested, I was able to loop over every volume in 
vm_start_lock() and the threshold is being set correctly.

Thanks!

Best regards,

Tiago


[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel