Re: [pve-devel] [PATCH qemu-server 13/14] blockdev: add backing_chain support

["DERUMIER, Alexandre via pve-devel" <pve-devel@lists.proxmox.com>]

[-- Attachment #1: Type: message/rfc822, Size: 13604 bytes --]

From: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>
To: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>, "f.gruenbichler@proxmox.com" <f.gruenbichler@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server 13/14] blockdev: add backing_chain support
Date: Wed, 28 May 2025 09:08:54 +0000
Message-ID: <ed6c67c51fc71cc8a739361a8c7dbee17f83c335.camel@groupe-cyllene.com>

>
>  
> +sub generate_backing_blockdev {

>>make this private?

perl question: how to call a resursive private sub ? (it don't seem to
allow it)



> +    my ($storecfg, $snapshots, $deviceid, $drive, $snap_id) = @_;
> +
> +    my $snapshot = $snapshots->{$snap_id};
> +    my $parentid = $snapshot->{parent};
> +
> +    my $volid = $drive->{file};
> +
> +    my $snap_file_blockdev = generate_file_blockdev($storecfg,
> $drive, $snap_id);
> +    $snap_file_blockdev->{filename} = $snapshot->{file};
> +    $drive->{ro} = 1;
> +    my $snap_fmt_blockdev = generate_format_blockdev($storecfg,
> $drive, $snap_file_blockdev, $snap_id);
> +    $snap_fmt_blockdev->{backing} =
> generate_backing_blockdev($storecfg, $snapshots, $deviceid, $drive,
> $parentid) if $parentid;
> +    return $snap_fmt_blockdev;
> +}
> +
> +sub generate_backing_chain_blockdev {
> +    my ($storecfg, $deviceid, $drive) = @_;
> +
> +    my $volid = $drive->{file};
> +    my $snapshot_type = PVE::Storage::volume_has_feature($storecfg,
> 'snapshot', $volid);
> +    return if !$snapshot_type || $snapshot_type != 3;

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel