[pve-devel] SPAM: [PATCH manager v2] ui: dc summary: fix calculation of storage size

[Igor Thaller via pve-devel <pve-devel@lists.proxmox.com>]

[-- Attachment #1: Type: message/rfc822, Size: 5537 bytes --]

From: Igor Thaller <igor.thaller@aon.at>
To: pve-devel@lists.proxmox.com
Subject: SPAM: [PATCH manager v2] ui: dc summary: fix calculation of storage size
Date: Wed, 31 Jul 2024 14:14:09 +0200
Message-ID: <20240731121409.639432-1-igor.thaller@aon.at>

The issue is related to the 'Summary' tab under 'Datacenter' inside a
cluster. To get a steady reading of the storage size data, the frontend
requests the '/api2/json/cluster/resources' every three seconds to
retrieve the necessary data to calculate the used and total storage
size.

The problem occurs when a shared storage is defined and a node goes
offline. As the node is not online, it cannot report the shared storage
size (both used and total) back to the other nodes. The order of the
JSON response is not always the same, so it is possible that the offline
node will appear first. Consequently, the frontend will display the
wrong total and used storage. This is because the shared storage data
has both the maximum disk size and the used disk set to zero when the
node is offline. This causes the total and used space data to be
calculated and displayed incorrectly, leading to fluctuations in the
displayed percentage of used disk space.

To fix this, add a conditional check to skip the storage report if its
status is 'unknown' (regardless of if the storage is local or shared).
This prevents the unreliable data from being processed.

Reported-by: Friedrich Weber <f.weber@proxmox.com>
Signed-off-by: Igor Thaller <igor.thaller@aon.at>
---

Notes:
    Changes from v1 -> v2
    * Ignore all storages of status unknown instead of ignoring just shared
      storages with status unknown (thanks Fiona)
    * Move the testing comments to the notes (thanks Fiona)
    * Reword sentence describing the problem
    
    To test these changes, adjust the 'max_requests' variable in the Perl
    script located at '/usr/share/perl5/PVE/Service/pveproxy.pm' to increase
    the likelihood of the error to occur. This makes the storage size
    fluctuations more frequent. Then compare the storage results (both used
    and total sizes) before and after implementing the fix.
    
    Note: Be aware that it takes around one minute for the spike to happen.

 www/manager6/dc/Summary.js | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/www/manager6/dc/Summary.js b/www/manager6/dc/Summary.js
index efb44dae..ae3f9566 100644
--- a/www/manager6/dc/Summary.js
+++ b/www/manager6/dc/Summary.js
@@ -170,6 +170,11 @@ Ext.define('PVE.dc.Summary', {
 			} else if (countedStorage[sid]) {
 			    break;
 			}
+
+			if (data.status === "unknown") {
+			    break;
+			}
+
 			used += data.disk;
 			total += data.maxdisk;
 			countedStorage[sid] = true;
-- 
2.39.2



[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel