public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Severen Redwood via pve-devel <pve-devel@lists.proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Severen Redwood <severen.redwood@sitehost.co.nz>,
	t.lamprecht@proxmox.com
Subject: [pve-devel] [PATCH cluster v3 5/6] cluster files: add used_vmids.list
Date: Tue,  5 Nov 2024 15:00:53 +1300	[thread overview]
Message-ID: <mailman.720.1730772147.332.pve-devel@lists.proxmox.com> (raw)
In-Reply-To: <20241105020054.215734-1-severen.redwood@sitehost.co.nz>

[-- Attachment #1: Type: message/rfc822, Size: 4190 bytes --]

From: Severen Redwood <severen.redwood@sitehost.co.nz>
To: pve-devel@lists.proxmox.com
Cc: a.lauterer@proxmox.com, t.lamprecht@proxmox.com, Severen Redwood <severen.redwood@sitehost.co.nz>, Daniel Krambrock <krambrock@hrz.uni-marburg.de>
Subject: [PATCH cluster v3 5/6] cluster files: add used_vmids.list
Date: Tue,  5 Nov 2024 15:00:53 +1300
Message-ID: <20241105020054.215734-5-severen.redwood@sitehost.co.nz>

Add `/etc/pve/used_vmids.list` to the list of cluster files, which will
be used for recording previously used VM/CT IDs. This is required so
that we can optionally ensure that such IDs are not suggested by the
`/cluster/nextid` API endpoint.

Co-authored-by: Daniel Krambrock <krambrock@hrz.uni-marburg.de>
Signed-off-by: Severen Redwood <severen.redwood@sitehost.co.nz>
---
There are no changes to this patch since v2.

 src/PVE/Cluster.pm  | 1 +
 src/pmxcfs/status.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/src/PVE/Cluster.pm b/src/PVE/Cluster.pm
index f899dbe..059c7af 100644
--- a/src/PVE/Cluster.pm
+++ b/src/PVE/Cluster.pm
@@ -84,6 +84,7 @@ my $observed = {
     'virtual-guest/profiles.cfg' => 1,
     'mapping/pci.cfg' => 1,
     'mapping/usb.cfg' => 1,
+    'used_vmids.list' => 1,
 };
 
 sub prepare_observed_file_basedirs {
diff --git a/src/pmxcfs/status.c b/src/pmxcfs/status.c
index dc44464..7f60145 100644
--- a/src/pmxcfs/status.c
+++ b/src/pmxcfs/status.c
@@ -114,6 +114,7 @@ static memdb_change_t memdb_change_array[] = {
 	{ .path = "firewall/cluster.fw" },
 	{ .path = "mapping/pci.cfg" },
 	{ .path = "mapping/usb.cfg" },
+	{ .path = "used_vmids.list" },
 };
 
 static GMutex mutex;
-- 
2.47.0



[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

  parent reply	other threads:[~2024-11-05  2:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-05  1:58 [pve-devel] [PATCH SERIES v3] Add ability to prevent suggesting previously used VM/CT IDs Severen Redwood via pve-devel
2024-11-05  2:00 ` [pve-devel] [PATCH manager v3 1/2] close #4369: api: optionally only suggest unique IDs Severen Redwood via pve-devel
     [not found] ` <20241105020054.215734-1-severen.redwood@sitehost.co.nz>
2024-11-05  2:00   ` [pve-devel] [PATCH manager v3 2/2] close #4369: ui: add datacenter option for unique VM/CT IDs Severen Redwood via pve-devel
2024-11-05  2:00   ` [pve-devel] [PATCH container v3] api: record CT ID as used after a container is destroyed Severen Redwood via pve-devel
2024-11-05  2:00   ` [pve-devel] [PATCH qemu-server v3] api: record VM ID as used after a virtual machine " Severen Redwood via pve-devel
2024-11-05  2:00   ` Severen Redwood via pve-devel [this message]
2024-11-05  2:00   ` [pve-devel] [PATCH cluster v3 6/6] datacenter config: add unique-next-id to schema Severen Redwood via pve-devel
     [not found]   ` <20241105020054.215734-3-severen.redwood@sitehost.co.nz>
2024-11-05 15:49     ` [pve-devel] [PATCH container v3] api: record CT ID as used after a container is destroyed Aaron Lauterer
     [not found]   ` <20241105020054.215734-4-severen.redwood@sitehost.co.nz>
2024-11-05 15:50     ` [pve-devel] [PATCH qemu-server v3] api: record VM ID as used after a virtual machine " Aaron Lauterer
2024-11-05 15:53   ` [pve-devel] [PATCH manager v3 1/2] close #4369: api: optionally only suggest unique IDs Aaron Lauterer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mailman.720.1730772147.332.pve-devel@lists.proxmox.com \
    --to=pve-devel@lists.proxmox.com \
    --cc=severen.redwood@sitehost.co.nz \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal